Skip to content

Speed Up Alert is shown for Solana Transactions #42379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 6 tasks
Douglashdaniel opened this issue Nov 19, 2024 · 2 comments · Fixed by brave/brave-core#26646
Closed
3 of 6 tasks

Speed Up Alert is shown for Solana Transactions #42379

Douglashdaniel opened this issue Nov 19, 2024 · 2 comments · Fixed by brave/brave-core#26646
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.73.x - Release #3

Comments

@Douglashdaniel
Copy link

Description

Currently when making a Solana transaction, the Speed Up alert is being displayed in the Post Confirmation screen.

Steps to reproduce

  1. Open the Wallet, then Create and Submit a Solana transaction
  2. Wait for the Post Confirmation panel to show up
  3. The Speed Up alert will be displayed.

Actual result

Is showing the Speed Up alert

Expected result

Speed Up should only be available for ETH CoinType transactions.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.73.89 Chromium: 131.0.6778.69 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@Douglashdaniel Douglashdaniel added bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include labels Nov 19, 2024
@Douglashdaniel Douglashdaniel self-assigned this Nov 19, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 19, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Nov 19, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Nov 20, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 20, 2024
This was referenced Nov 20, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.73.92 or higher for 1.73.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.73.92 Chromium: 131.0.6778.85 (Official Build) (64-bit)
Revision 05f178377f490b21d73d0a9bb29c2e45040dd984
OS Windows 11 Version 23H2 (Build 22631.4460)
  • Verified steps from issue description
  • Verified Speed up alert is not shown for Solana transactions
42379.mp4

@LaurenWags LaurenWags mentioned this issue Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.73.x - Release #3
Development

Successfully merging a pull request may close this issue.

fix(wallet): Only Show Speed Up Alert for ETH CoinType brave/brave-core
4 participants
@kjozwiak @srirambv @Douglashdaniel @brave-builds