Bad Swedish translation in Shields parts of browser. Looks bad and not professional.

[nesalkiN]

How to get in contact with people responsible for the translation in the apps? Especially the stuff related to Shields? I have tried in the forum and applied over att Trasfirex but never got anything back. The Swedish translation for Shields is bad and makes the projekt look less professional. Some strings look as they have been directly translated from English, word for word without thinking about context so the lines just doesn't work in Swedish. I absolutely can help. I have been involved in several different open projects translating from English to Swedish. Tell me how I could help.

You can also see my thread here
https://community.brave.com/t/swedish-translation-needs-some-tuning/573380

Thanks!

[AndyAnds265]

hey @nesalkiN - thank you for bringing this up. We are in the process of re-working all languages and choosing better terms to represent the product features that we have. Once we do this we'll be making updates across the board.

I'll update this ticket + your Community thread as soon as we have deployed updates.

[nesalkiN]

Great. Thanks. Please don't translate Shield or Shields to Sköld or Sköldar. Same meaning in Swedish but does not make good sense to use it translated. Shield(s) is fine. We know English here. ;) The product name is Shields. But I think I got that down in the community thread.

[nesalkiN]

Still looks unprofessional. Gave you correct translations in my forum post, just replace. ;) I had done it myself if the platform for translations where open.

[kjozwiak]

The above requires 1.76.72 or higher for 1.76.x verification 👍

[LaurenWags]

Verified with

Brave | 1.76.72 Chromium: 134.0.6998.39 (Official Build) (x86_64)
-- | --
Revision | 1dc74433b3b38006a610d5d82eb39094beb08361
OS | macOS Version 14.7.4 (Build 23H420)

Compared translations from 1.75.181 Chromium: 133.0.6943.141 to 1.76.72 Chromium: 134.0.6998.39 for shields. Some minor changes observed.

1.75.181 Chromium: 133.0.6943.141	1.76.72 Chromium: 134.0.6998.39

[nesalkiN]

Verified with

Brave | 1.76.72 Chromium: 134.0.6998.39 (Official Build) (x86_64)
-- | --
Revision | 1dc74433b3b38006a610d5d82eb39094beb08361
OS | macOS Version 14.7.4 (Build 23H420)

Compared translations from 1.75.181 Chromium: 133.0.6943.141 to 1.76.72 Chromium: 134.0.6998.39 for shields. Some minor changes observed.

1.75.181 Chromium: 133.0.6943.141 1.76.72 Chromium: 134.0.6998.39

Looking much better but the space between "Shields är inaktiverat för" and the url is missing. See the last screenshot where it says "Shields är inaktiverat förbrave.com". This is mainly noticeable with short URLs. Longer ones wrap after "för" sometimes.

[mkarolin]

Looking much better but the space between "Shields är inaktiverat för" and the url is missing. See the last screenshot where it says "Shields är inaktiverat förbrave.com". This is mainly noticeable with short URLs. Longer ones wrap after "för" sometimes.

This seems to be programmatic. It doesn't always reproduce - I had to restart the browser a few times to show up like that. @fallaciousreasoning any ideas? It's https://github.com/brave/brave-core/blob/master/components/brave_shields/resources/panel/components/main-panel/index.tsx#L162-L166

[fallaciousreasoning]

Hmm I can't see why it would sometimes have the space - maybe replacing the {' '} with   (for space) or   (for a no break space) would stop it being inconsistent.

Separately, I think they string we have for translation is wrong:

1. The bit that it says is meant to be in tags is not in tags
2. The translation string assumes the host should always come after the Shields are up for string (possibly in some languages it belongs in the middle, or at the start).

I think the translation string should be something more like this:

  <message name="IDS_BRAVE_SHIELDS_UP" desc="Status label for when Brave Shields is enabled.">
    <ph name="STATUS_BEFORE">$1</ph>Shields are UP<ph name="STATUS_AFTER">$2</ph> for <ph name="HOST">$3</ph>
  </message>

  <message name="IDS_BRAVE_SHIELDS_DOWN" desc="Status label for when Brave Shields is disabled.">
    <ph name="STATUS_BEFORE">$1</ph>Shields are DOWN<ph name="STATUS_AFTER">$2</ph> for <ph name="HOST">$3</ph>
  </message>

We'll have to update the frontend to render it properly too.