Skip to content

Fix Sign Typed Data V3 and Sign Typed Data V4 on Trezor devices #41864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
supermassive opened this issue Oct 24, 2024 · 1 comment · Fixed by brave/brave-core#26165
Closed

Fix Sign Typed Data V3 and Sign Typed Data V4 on Trezor devices #41864

supermassive opened this issue Oct 24, 2024 · 1 comment · Fixed by brave/brave-core#26165
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.74.x - Release

Comments

@supermassive
Copy link

Doesn't work for devices newer than T1B1
@supermassive supermassive self-assigned this Oct 24, 2024
@supermassive supermassive mentioned this issue Oct 24, 2024
Merged
24 tasks
@yrliou yrliou added this to Web3 Oct 24, 2024
@yrliou yrliou moved this to In Review in Web3 Oct 24, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Oct 30, 2024
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 30, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 30, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.74.5 Chromium: 131.0.6778.69 (Official Build) beta (64-bit)
Revision fbd7c390a7daa54f1aac2c769076d3fecf7c7fc7
OS Windows 11 Version 23H2 (Build 22631.4460)
  • Verified steps from brave/brave-core#26165
  • Verified Sign Typed Data V3 and Sign Typed Data V4 transactions work with Trezor hardware wallet accounts
41864.mp4

@LaurenWags LaurenWags mentioned this issue Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.74.x - Release
Development

Successfully merging a pull request may close this issue.

Support signing typed data on Trezor devices brave/brave-core
3 participants
@supermassive @srirambv @brave-builds