Skip to content

[Wallet/iOS] Transaction Status will be dismissed automatically after tx gets confirmed #41563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks
nuo-xu opened this issue Oct 10, 2024 · 2 comments · Fixed by brave/brave-core#25957
Closed
5 tasks

[Wallet/iOS] Transaction Status will be dismissed automatically after tx gets confirmed #41563

nuo-xu opened this issue Oct 10, 2024 · 2 comments · Fixed by brave/brave-core#25957
Assignees
@nuo-xu
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes regression release-notes/exclude
Milestone
1.70.x - Release #5

Comments

@nuo-xu
Copy link

nuo-xu commented Oct 10, 2024

Description

Transaction Status will be dismissed automatically after tx gets confirmed

Steps to reproduce

  1. Open wallet
  2. make a send or swap tx
  3. confirm the tx

Actual result

tx starts to showing the loader and the whole screen will get dismissed

Expected result

screen should stay with tx status displayed until user closes the screen.

Reproduces how often

Easily reproduced

Brave version

all

Device/iOS version

iOS 18

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@nuo-xu nuo-xu added bug OS/iOS Fixes related to iOS browser functionality QA/Yes regression release-notes/exclude labels Oct 10, 2024
@nuo-xu nuo-xu self-assigned this Oct 10, 2024
@nuo-xu nuo-xu added this to Web3 Oct 10, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Oct 11, 2024
@nuo-xu nuo-xu mentioned this issue Oct 11, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Oct 14, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 14, 2024
This was referenced Oct 14, 2024
Merged
Merged
@nuo-xu nuo-xu mentioned this issue Oct 14, 2024
Merged
24 tasks
@kjozwiak
Copy link
Member

The above requires 1.70.127 or higher for 1.70.x verification 👍

@kjozwiak kjozwiak added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 15, 2024
@kjozwiak kjozwiak mentioned this issue Oct 15, 2024
Closed
19 tasks
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.0 using version 1.70 (127)

Test Steps:

  1. open wallet
  2. make a send or swap tokens
  3. confirm the txn
  • Ensured screen stays with the transaction status until transaction is completed and user can close it.
example example example example example
Image Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes regression release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.70.x - Release #5
4 participants
@nuo-xu @kjozwiak @Uni-verse @brave-builds