Skip to content

Move Activity Tab into Panel Portfolio View #41498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Douglashdaniel opened this issue Oct 8, 2024 · 2 comments · Fixed by brave/brave-core#25896
Closed

Move Activity Tab into Panel Portfolio View #41498

Douglashdaniel opened this issue Oct 8, 2024 · 2 comments · Fixed by brave/brave-core#25896
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.73.x - Release

Comments

@Douglashdaniel
Copy link

Platforms

all, Windows, macOS, Linux

Description

To prepare for the new Connection tab in the Panel, we need to move the Activity tab into the Portfolio view under the Segmented Controller.

  • Activity should now live on the Portfolio view as an option in the Portfolio Segmented Controller.
  • There should no longer be an Activity button in the main Panel navigation.
  • No changes should be made for the Wallet Desktop view.

Image
@Douglashdaniel Douglashdaniel added enhancement feature-request feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes QA/Yes release-notes/include labels Oct 8, 2024
@Douglashdaniel Douglashdaniel self-assigned this Oct 8, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Oct 8, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Oct 8, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Oct 8, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Oct 9, 2024
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Oct 9, 2024
@LaurenWags
Copy link
Member

@Douglashdaniel please add the following required labels:

  • OS/Desktop and/or OS/Android and/or OS/iOS

Thanks!

@srirambv
Copy link
Contributor

srirambv commented Oct 22, 2024 •
edited
Loading

Verification passed on

Brave 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
Revision 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS Windows 11 Version 23H2 (Build 22631.4317)
  • Verified steps from brave/brave-core#25896
  • Verified Activity tab is shown in Segmented Controller in panel
  • Verified Activity works as expected
  • Verified there is no Activity tab in main wallet panel
  • Verified nothings changed on Wallet desktop view
41498.mp4

Verification passed on

Brave 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
Revision 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS Linux
  • Verified steps from brave/brave-core#25896
  • Verified Activity tab is shown in Segmented Controller in panel
  • Verified Activity works as expected
  • Verified there is no Activity tab in main wallet panel
  • Verified nothings changed on Wallet desktop view
41498.mp4

Verification passed on

Brave 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (arm64)
Revision 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS macOS Version 15.0.1 (Build 24A348)
  • Verified steps from brave/brave-core#25896
  • Verified Activity tab is shown in Segmented Controller in panel
  • Verified Activity works as expected
  • Verified there is no Activity tab in main wallet panel
  • Verified nothings changed on Wallet desktop view
41498.mov

@LaurenWags LaurenWags mentioned this issue Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Move Activity to Portfolio View in Panel brave/brave-core
4 participants
@srirambv @LaurenWags @Douglashdaniel @brave-builds