[Wallet/iOS] User Assets are deletable

[nuo-xu]

Description

Wallet should only provide deletion option for custom user assets

Steps to reproduce

1. Open wallet and login with QA wallet
2. Let the wallet loads all the auto-discovery assets
3. Open edit user assets
4. Find BAT on Ethereum and try to swipe row to the left

Actual result

Deletion option is available

Expected result

Deletion option should be unavailable

Reproduces how often

Easily reproduced

Brave version

1.70.x and after

Device/iOS version

all

Affected browser versions

• latest AppStore
• latest TestFlight
• previous TestFlight

Reproducibility

• with Brave Shields disabled
• in the latest version of mobile Safari

Miscellaneous information

No response

[nuo-xu]

Update: will match desktop only allow deletion on NFTs. Reference: https://github.com/brave/brave-core/blob/087482aabf21a34d460885e1355f9b1c21f5047e/components/brave_wallet_ui/components/desktop/popup-modals/edit-visible-assets-modal/virtualized-visible-assets-list.tsx#L62
iOS does not have the ability to edit token. Since we have our own logic to avoid auto-discovery re-add back user deleted token, i think we are safe to make not only NFTs but also user added custom tokens deletable.

[kjozwiak]

The above requires 1.70.126 or higher for 1.70.x verification 👍 The crash that @srirambv found while verifying the above will be fixed via brave/brave-core#25804 and will also be uplifted into 1.71.x & 1.70.x via brave/brave-core#25884 & brave/brave-core#25885.

[Uni-verse]

Verified on iPhone 12 running iOS 18 using version 1.70 (127)

• Verified STR in test plan mentioned in fix(wallet): Update remove asset logic brave-core#25805 (comment)
  • Ensured that only NFT assets are deletable
  • Ensured that crash does not occur when swiping to delete NFT assets.

example	example	example