Skip to content

[Android] Advanced server selection follow up #41106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deeppandya opened this issue Sep 17, 2024 · 3 comments · Fixed by brave/brave-core#25604
Closed

[Android] Advanced server selection follow up #41106

deeppandya opened this issue Sep 17, 2024 · 3 comments · Fixed by brave/brave-core#25604
Assignees

Comments

@deeppandya
Copy link
Contributor

Description

Based on the suggestions from guardian team and as a follow up to #36277, we need to update existing changes to include country and continent variables in the Region.
We also need to update the logic around the way we persist and identify selected region after an upgrade.

Test Plan :

Please follow the test plan mentioned in the main PR : brave/brave-core#25089

@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2024

Marking as QA/Blocked as #41477 is known issue which is waiting on #25604 to be uplifted

@kjozwiak
Copy link
Member

The above requires 1.71.112 or higher for 1.71.x verification 👍 The above can be verified alongside #36277 once we start running through the VPN feature via 1.71.x.

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 12, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 12, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240823.009 release-keys
Brave build: 1.71.112
Chromium: 130.0.6723.44 (Official Build) (64-bit) 

"Automatic" server location

STEPS:

  1. Buy an IAP subscription on a fresh profile
  2. Create a VPN profile
  3. Turn on VPN
  4. Go to the Server selection page
  5. Verify that Automatic must be selected

ACTUAL RESULTS:

  • Verified that Automatic location is selected by default when enabling VPN

1 2 3
1 2 3
1 2 3
"Optimal" server location from the selected region

STEPS:

  1. Go to Server selection page
  2. Disable Automatic toggle switch > Verify that your region (USA in my case) is selected by default
  3. Select the USA as a region
  4. On the next page, select Optimal
  5. Verify that the Best server location would be selected and it could give a different location based on the available resources on the location at the time

ACTUAL RESULTS:

  • Verified that your region (USA in my case) is selected by default after disabling the Automatic toggle switch.
  • Verified that the Best server location must be selected when tapping on Optimal, and it could give a different location based on the available resources at the time.

1 2 3
1 2 3
1 2 3
"Specific" server selection

STEPS:

  1. Go to Server selection page
  2. Select the USA as a region
  3. On the next page, select Atlanta
  4. Verify that Atlanta must be selected as server location

ACTUAL RESULTS:

  • Verified that a specific city/server must be selected as server location when tapping the city name.

1 2 3 4
1 2 3 4
"Upgrade" scenario

STEPS:

  1. Install and launch Brave 1.70.123 > Purchase/enable VPN > Verify VPN server selection screen UI
  2. Upgrade Brave to 1.71.112 > Enable VPN > Go to the Server selection page
  3. Verify that the Selected region from the previous version must be selected in the new UI
  4. Tap on the region
  5. Verify that Optimal must be selected as we didn't have a granular details from the previous version. A new version of the app would follow the new changes moving forward.

ACTUAL RESULTS:

  • Verified that Automatic is NOT selected after Brave upgrade.
  • Verified that the previously selected region is still selected after Brave upgrade.
  • Verified that the Optimal server location is selected by default after Brave upgrade as we didn't have granular details from the previous version. A new version of the app would follow the new changes moving forward.
  • Verified that multiple radio buttons can't be selected at the same time

Before upgrade After upgrade
1 2
1 2
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants