Skip to content

Fix safe browsing #41060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 6 tasks
samartnik opened this issue Sep 13, 2024 · 2 comments · Fixed by brave/brave-core#25562
Closed
3 of 6 tasks

Fix safe browsing #41060

samartnik opened this issue Sep 13, 2024 · 2 comments · Fixed by brave/brave-core#25562

Comments

@samartnik
Copy link
Contributor

Description

Safe browsing stopped working since 1.69.145. We need to fix it.

Steps to reproduce

  1. Goto https://testsafebrowsing.appspot.com
  2. Click first link.
  3. There is some web site content instead of dangerous site page.

Actual result

There is some web site content

Expected result

Dangerous site page

Reproduces how often

Easily reproduced

Brave version

1.69.145 and higher

Device

  • Brand/model: any
  • Android version: any

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Sep 17, 2024

The above requires 1.70.114 or higher for 1.70.x verification 👍 @hffvld @Uni-verse can also use brave/brave-core#25562 (comment) as a template for 1.70.x verification.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 17, 2024
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 & Samsung Galaxy S21 running Android 13 using version 1.70.114

  • Ensured Safe Browsing protection is enabled when using test links in https://testsafebrowsing.appspot.com
  • Ensured that warning interstitial is displayed when navigating to a malicious/dangerous website when Safe Browsing is enabled.
  • Ensured that user is able to navigate back by tapping on Back to safety on the warning interstitial page.
  • Ensured that clicking through the warning interstitial is successful.
example example example
Screenshot 2024-09-17 at 12 59 08 PM Screenshot 2024-09-17 at 12 58 51 PM Screenshot 2024-09-17 at 12 58 58 PM
Screenshot 2024-09-17 at 2 14 50 PM Screenshot 2024-09-17 at 2 15 27 PM Screenshot 2024-09-17 at 2 15 48 PM

@Uni-verse Uni-verse added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants