Skip to content

Connect button overlaps on the text #40930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 6 tasks
srirambv opened this issue Sep 9, 2024 · 5 comments
Open
1 of 6 tasks

Connect button overlaps on the text #40930

srirambv opened this issue Sep 9, 2024 · 5 comments
Labels
design A design change, especially one which needs input from the design team feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2024

Description

Connect button overlaps on the text

Steps to reproduce

  1. Install 1.71.72
  2. Select VPN menu and connect to a server
  3. Scroll down to US
  4. Connect button overlaps on text

Actual result

image image

Expected result

TBD

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.71.72 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit)
Revision 7661000529b73e155d9386d67d2508cc6b71f6b5
OS Windows 11 Version 23H2 (Build 22631.4037)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Will also be an issue when using it on other locales
cc: @rebron @aguscruiz @MadhaviSeelam @GeetaSarvadnya @mattmcalister

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude OS/Desktop labels Sep 9, 2024
@mattmcalister mattmcalister added priority/P3 The next thing for us to work on. It'll ride the trains. feature/vpn labels Sep 9, 2024
@aguscruiz
Copy link

This is the intended behavior, it's supposed to overlap, since it only appears on the hover state

@mattmcalister
Copy link

it does seem odd to me @aguscruiz . can we consider a different treatment?

@aguscruiz
Copy link

The other alternative I had in mind was to just crop the city name ### only on hover, when it exceeds the place "Connect" would take. What do you think?

Image

An alternative was to just use an icon instead of the "connect" but I don't know if just an icon could be easy enough to understand.

@mattmcalister
Copy link

👍 cropping the city name on hover works better than overlapping the text, imo.

@aguscruiz
Copy link

Created an issue for this here:
#41619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants