Skip to content

[Leo] Add search query and summary from Brave Search SERP when available #40615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yrliou opened this issue Aug 22, 2024 · 1 comment · Fixed by brave/brave-core#25257
Closed

[Leo] Add search query and summary from Brave Search SERP when available #40615

yrliou opened this issue Aug 22, 2024 · 1 comment · Fixed by brave/brave-core#25257
Assignees
@yrliou
Labels
browser-ai feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Aug 22, 2024 •
edited
Loading

Platforms

Linux, macOS, Windows

Description

Add search query and summary from Brave Search SERP to conversation history when summarizer-key tag is present.
Note that it only happen on Brave Search SERP when user has opted in to Leo and page context is not unlinked.
This issue is to track the implementation of requirement # 1 in https://docs.google.com/document/d/1idelFPpUEcKDNcyKYf3M5yw91tuIddjrlYfpaWEJjNk/edit
@yrliou yrliou self-assigned this Aug 22, 2024
@yrliou yrliou mentioned this issue Aug 22, 2024
Merged
24 tasks
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 23, 2024
@mattmcalister mattmcalister moved this to In Progress in Browser AI Aug 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI Aug 29, 2024
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 29, 2024
@srirambv
Copy link
Contributor

srirambv commented Oct 3, 2024

Verification passed on

Brave 1.71.102 Chromium: 129.0.6668.70 (Official Build) beta (64-bit)
Revision d901535b1091c5f39eb2b5426b8fa8e7f3c5edf0
OS Windows 11 Version 23H2 (Build 22631.4169)
  • Verified steps from brave/brave-core#25257
  • Verified asking a query in https://search.brave.com and selecting Answer with AI generates the summary
  • Verified selecting Leo from sidebar automatically populates the query and summary
  • Verified toggle page context to off, removes the staged question and summary
  • Verified toggle page context to on, re-adds the staged question and summary
  • Verified follow up questions works as expected
40615.mp4

@LaurenWags LaurenWags mentioned this issue Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
browser-ai feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Add search query and summary from Brave Search SERP when open Leo chat brave/brave-core
4 participants
@mattmcalister @yrliou @srirambv @brave-builds