Skip to content

Changing theme via system settings, Networks list is not shown #40496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
srirambv opened this issue Aug 16, 2024 · 1 comment · Fixed by brave/brave-core#25247
Closed
2 of 6 tasks

Changing theme via system settings, Networks list is not shown #40496

srirambv opened this issue Aug 16, 2024 · 1 comment · Fixed by brave/brave-core#25247
Assignees
@simoarpe
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 16, 2024 •
edited
Loading

Description

Changing theme via system settings, Networks list is not shown

Steps to reproduce

  1. Set device theme to dark theme
  2. Open Settings -> Brave Wallet -> Networks
  3. Change theme to light via action centre
  4. Network list is not shown

Actual result

Network.list.mp4

Expected result

Should show the network list irrespective of device theme

Reproduces how often

Easily reproduced

Brave version

1.69.147

Device

  • Brand/model: Google Pixel 8
  • Android version: 14

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @simoarpe @deeppandya
@srirambv srirambv added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Aug 16, 2024
@srirambv srirambv added this to Web3 Aug 16, 2024
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 16, 2024
@simoarpe simoarpe moved this from Backlog to In Progress in Web3 Aug 21, 2024
@simoarpe simoarpe mentioned this issue Aug 21, 2024
Merged
24 tasks
@simoarpe simoarpe moved this from In Progress to In Review in Web3 Aug 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Aug 21, 2024
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 21, 2024
@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.71.97 x64 Beta build

  • Verified steps from issue description and brave/brave-core#25247
  • Verified changing theme from system settings, Network list continues to show
  • Verified all networks are shown when theme is changed
40496.mp4

@hffvld hffvld mentioned this issue Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Notify activity recreation when changing theme from network settings brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds