Skip to content

"Bring all tabs to this window" unexpectedly brings PWAs into the window as tabs #40287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
mdemoss opened this issue Aug 5, 2024 · 3 comments · Fixed by brave/brave-core#24995
Closed
1 of 6 tasks

Comments

@mdemoss
Copy link

mdemoss commented Aug 5, 2024

Description

"Bring all tabs to this window" unexpectedly brings PWAs (portable web applications) into the window as tabs. This can't be easily undone except by re-launching the PWA.

Steps to reproduce

  1. Install a web application as a PWA
  2. Launch PWA in its own window
  3. Choose "Bring all tabs to this window" from the tab context window in another window.

Actual result

PWAs move to the window as though they were tabs.

Expected result

PWAs are expected to behave more like independent applications and shouldn't be pulled in as tabs in this way.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.134 Chromium: 127.0.6533.88 (Official Build) (64-bit)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Behavior seems the same on "real" PWAs and on ordinary web pages installed as PWAs.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 6, 2024

The above requires 1.69.137 or higher for 1.69.x verification 👍

@stephendonner
Copy link

stephendonner commented Aug 7, 2024

Verification PASSED using

Brave | 1.69.137 Chromium: 127.0.6533.100 (Official Build) beta (64-bit)
-- | --
Revision | 40b6ccbd1eb76c8f575e83de8ad81c4349d3f32a
OS | Windows 10 Version 22H2 (Build 19045.4717)

Steps:

  1. installed 1.69.137
  2. launched Brave
  3. loaded pokedex.org
  4. installed the PWA from the URL-bar's icon
  5. opened a couple windows (not tabs)
  6. context-clicked on a window's tab
  7. chose Bring all tabs to this window

Confirmed the Pokedex PWA window/tab wasn't folded into the above set of tabs

example example example example
image image image image

@JoshuaMacklin
Copy link

JoshuaMacklin commented Oct 24, 2024

The previous unintended behavior maybe a quick way to implement a Firefox Multi-Account Container type feature.
#34
#6346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment