Skip to content

Brave does not save the password #39980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
H-COOOH opened this issue Jul 25, 2024 · 9 comments
Closed
1 of 6 tasks

Brave does not save the password #39980

H-COOOH opened this issue Jul 25, 2024 · 9 comments
Assignees

Comments

@H-COOOH
Copy link

H-COOOH commented Jul 25, 2024

Description

The Brave password manager does not store passwords any more.

Steps to reproduce

  1. open brave://password-manager/settings
  2. Import passwords > Select file
  3. import was successful
  4. close tab brave://password-manager/settings
  5. reopen tab brave://password-manager/passwords
  6. all the passwords disappear

Actual result

step 6 passwords disappear

Expected result

step 6 passwords won't disappear

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.68.128 Chromium: 127.0.6533.73 (Official Build) (64-bit)
Revision: 800676fd9ede2eb4174bac98c186e53749c7201f
OS: Windows 10 Version 22H2 (Build 19045.4651)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@MaxTheDesertMan
Copy link

This has happened to my already-stored passwords as well after this update. They're suggested as autofill data and they exist in the Login Data file but password manager is empty and the export option isn't there.

I tried adding a new password and exporting, but it only exports the new one (which disappears if I close password manager and open it again)

@H-COOOH
Copy link
Author

H-COOOH commented Jul 25, 2024

This has happened to my already-stored passwords as well after this update. They're suggested as autofill data and they exist in the Login Data file but password manager is empty and the export option isn't there.

I tried adding a new password and exporting, but it only exports the new one (which disappears if I close password manager and open it again)

Hi, @MaxTheDesertMan I deleted file C:\Users\NAME_HERE\AppData\local\BraveSoftware\Brave-Browser-Beta\User Data\Default\Login Data and imported the passwords again, this worked for me. I guess maybe you could try this.

@lbr38
Copy link

lbr38 commented Jul 26, 2024

Having the same issue on Linux with latest Brave Version 1.68.128 Chromium: 127.0.6533.73

@oidualc
Copy link

oidualc commented Jul 26, 2024

Same issue in macOS, already stored passwords are not showing since 1.68 update. Not even the autofill works anymore. Downgrading to 1.67 restores the functionality, so the data is not lost, it's simply not accessible anymore.

@dev-jam
Copy link

dev-jam commented Jul 26, 2024

Same here in debian bookworm. 1.68 does not open kwallet5 anymore. Reverted to 1.67 where it still works.

@Fahl-Design
Copy link

Fahl-Design commented Jul 29, 2024

same here on Linux (Debian 12.6):

brave-browser 1.68.128 [Brave Browser/stable main]
├── ist installiert
└── The web browser from Brave

edit:
workaround: run with this flag to see passwords again

brave-browser --enable-features=SkipUndecryptablePasswords

edit2:
I still have this issue on Debian 12.6 with version 1.68.134

brave-browser 1.68.134 [Brave Browser/stable main]
├── ist installiert
└── The web browser from Brave
  • I can not see the saved and synced passwords without the feature flag "SkipUndecryptablePasswords"
  • I can not see the passwords after importing from CSV (without starting with feature flag)

@oidualc
Copy link

oidualc commented Jul 29, 2024

Apparently, this is a Chromium issue: https://issues.chromium.org/issues/354847250.
From Brave perspective, there is an ongoing discussion here: https://community.brave.com/t/aggregate-topic-lost-passwords-in-july-2024-update/560154.

@bsclifton
Copy link
Member

bsclifton commented Jul 29, 2024

This is basically a duplicate issue of #33548 - but this issue has some great info. I'll leave it open for now

@szilardszaloki is checking out the issue now 😄

Thanks for sharing the command line argument above --enable-features=SkipUndecryptablePasswords. This should get most people fixed up. Chromium also had a Windows specific fix that we've pulled in with brave/brave-core#24853. I'll get this pulled into our Beta and Release channels today

The super important thing is: there's no data loss, it's just not showing the passwords. I think even trying to use the passwords should work fine.

Thanks for properly capturing the Chromium issue @oidualc - we pulled that fix into Brave and will be merging to Beta and Release. Looks like in Chromium it's approved for merge into Chromium 127 and 128, which means we should see a Chromium bump coming soon for Brave too which has the fix.

@bsclifton
Copy link
Member

Closing in favor of #33548

@github-project-automation github-project-automation bot moved this to Completed in General Aug 2, 2024
@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Aug 2, 2024
@rebron rebron removed this from General Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants