Skip to content

Update Play Billing Library #39714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deeppandya opened this issue Jul 12, 2024 · 2 comments · Fixed by brave/brave-core#24623
Closed

Update Play Billing Library #39714

deeppandya opened this issue Jul 12, 2024 · 2 comments · Fixed by brave/brave-core#24623
Assignees

Comments

@deeppandya
Copy link
Contributor

Description

We need to upgrade billing client dependency to 7.0.0.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 19, 2024

Used the same STR/Cases that were completed via #40078 (comment) after discussing with @deeppandya.

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.69.147 Chromium: 128.0.6613.40 (Official Build) (64-bit)
--- | ---
Revision | d29b1747d0f906239936b0d94c40889920ebf2c0
OS | Android 15; Build/AP31.240617.015; 35; REL

Test Case #1 - New GPS Account (has never subscribed to premium)

  • created a brand new Google account and @deeppandya added it into the GPS internal release channel
  • verified that the new account had access to 1.69.147 Chromium: 128.0.6613.40 via the internal release test channel
  • downloaded/launched 1.69.147 Chromium: 128.0.6613.40
  • tapped on the Hamburger Menu -> VPN -> 7 Day Free Trial
  • ensured that the purchase card was being displayed without any issues
  • ensured that you can run through the Billing API and subscribe/enable VPN
Example Example Example Example Example Example Example Example
1000001999 1000002000 1000002001 1000002002 1000002003 1000002004 1000002005 1000002006

Test Case #2 - Using previous/older account (has subscribed to Premium before)

  • download/installed 1.68.137 Chromium: 127.0.6533.100
  • upgraded from 1.68.137 Chromium: 127.0.6533.100 --> 1.69.147 Chromium: 128.0.6613.40 via the internal test channel
  • tapped on the Hamburger Menu -> VPN -> 7 Day Free Trial
  • ensured that the purchase card was being displayed without any issues (used the test card for this case as discussed)
Example Example Example Example
1000002012 1000002013 1000002014 1000002015

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 19, 2024

Verified on Samsung Galaxy S21 running Android 13 using version:

Brave	1.69.147 Chromium: 128.0.6613.40 (Official Build) (64-bit) 
Revision	d29b1747d0f906239936b0d94c40889920ebf2c0
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Case: New GPS Account (never subscribed)

  • created a brand new Google account and added it into the GPS internal release channel
  • verified that the new account had access to 1.69.147 Chromium: 128.0.6613.40 via the internal release test channel
  • downloaded/launched 1.69.147 Chromium: 128.0.6613.40
  • tapped on the Hamburger Menu -> VPN -> 7 Day Free Trial
  • ensured that the purchase card was being displayed without any issues
  • ensured that you can run through the Billing API and subscribe/enable VPN
Example Example Example Example Example Example Example
Screenshot 2024-08-19 at 4 10 16 PM Screenshot 2024-08-19 at 4 02 39 PM Screenshot 2024-08-19 at 4 13 45 PM Screenshot 2024-08-19 at 4 13 57 PM Screenshot 2024-08-19 at 4 14 06 PM Screenshot 2024-08-19 at 4 14 31 PM Screenshot 2024-08-19 at 4 14 37 PM

Test Case: Existing GPS Account (subscribed before)

  • download/installed 1.68.137 Chromium: 127.0.6533.100
  • upgraded from 1.68.137 Chromium: 127.0.6533.100 --> 1.69.147 Chromium: 128.0.6613.40 via the internal test channel
  • tapped on the Hamburger Menu -> VPN -> 7 Day Free Trial
  • ensured that the purchase card was being displayed without any issues (used the test card for this case as discussed)
Example Example Example
Screenshot 2024-08-19 at 4 45 42 PM Screenshot 2024-08-19 at 4 45 58 PM Screenshot 2024-08-19 at 4 46 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants