Skip to content

[iOS] Per-site adblocking setting is all-or-nothing #39573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks
ShivanKaul opened this issue Jul 4, 2024 · 2 comments · Fixed by brave/brave-core#24530
Closed
5 tasks

[iOS] Per-site adblocking setting is all-or-nothing #39573

ShivanKaul opened this issue Jul 4, 2024 · 2 comments · Fixed by brave/brave-core#24530
Assignees
@cuba
Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@ShivanKaul
Copy link
Collaborator

Description

We let users choose between the following adblocking modes in the global Shields settings menu:

  1. Standard (default, 1p exception policy)
  2. Aggressive/Strict (no 1p exception policy)
  3. Off

However, on per-site Shields, we only let users choose between off and on.

Steps to reproduce

  1. Open per-site Shields on iOS
  2. Click Advanced
  3. See adblocking setting

Actual result

It's a boolean toggle

Expected result

It should be a 3-way toggle.
Global default should be respected until user makes a selection.

Reproduces how often

Easily reproduced

Brave version

All

Device/iOS version

All

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@ShivanKaul ShivanKaul added the OS/iOS Fixes related to iOS browser functionality label Jul 4, 2024
@cuba cuba mentioned this issue Jul 5, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 15, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 22, 2024 •
edited
Loading

Verified on iPad (7th Gen) running iPadOS 17.5.1 using version 1.69 (150)

Test Case: Migration (standard)

  1. Installed 1.68.141
  2. Confirmed Trackers & Ads Blocking is set to Standard by default
  3. Navigated to webpage, open the Shields Panel to confirm that boolean toggle state is ON
  4. Upgraded to 1.69 (150)
  5. Verified Standard setting is retained in global settings
  6. Verified Ads Blocking is set to Standard for the per site in Brave Shields
  7. Verified webpage & embedded video ads are blocked after migration in aggressive mode
  8. Verified changing per site setting
  9. Verified Ads Blocking are showing the correct value in Shields panel in Private mode
1.68 1.68 1.69 1.69 YT Private Tab
IMG_1583 2 IMG_1584 2 IMG_1585 2 IMG_1586 2 IMG_1587 2 IMG_1588

Test Case: Migration (aggressive)

  1. Installed 1.68.141
  2. Set Trackers & Ads Blocking to Aggressive mode in Brave Shields & Privacy
  3. Navigated to webpage, open the Shields Panel to confirm that boolean toggle state
  4. Upgraded to 1.69 (150)
  5. Verified Aggressive setting is retained in global settings
  6. Verified Ads Blocking is set to Aggressive for the per site in Brave Shields
  7. Verified webpage & embedded video ads are blocked after migration in aggressive mode
1.68 1.68 1.69 1.69
IMG_1572 2 IMG_1573 2 IMG_1574 2 IMG_1575 2

Test Case: Migration (disabled)

  1. Installed 1.68.141
  2. Set Trackers & Ads Blocking to Disabled mode in Brave Shields & Privacy settings
  3. Navigated to webpage, open the Shields Panel to confirm that boolean toggle state is OFF
  4. Upgraded to 1.69 (150)
  5. Verified Disabled setting is retained in global settings
  6. Verified Ads Blocking is set to Disabled for the per site in Brave Shields
  7. Verified ads are being shown on websites.
1.68 1.69 YT (ads)
IMG_1579 IMG_1581 IMG_1582

Test Case: Migration (Shields down)

  1. Installed 1.68.141
  2. Opened a website
  3. Disabled Shields in the panel
  4. Upgraded to 1.69.153
  5. Confirmed Shields are disabled for the webpage
  6. Confirmed Shields can be enabled after upgrading
  7. Confirmed the Ads Blocking settings have not changed
Example Example Example
IMG_1589 IMG_1590 IMG_1591

Test Case: Migration (Per site selection)

  1. Installed 1.68.141
  2. Opened a webpage
  3. Disabled Ads Blocking for that webpage only
  4. Upgraded to 1.69.153
  5. Confirmed global ads blocking setting is set to Standard
  6. Confirmed per site selection is retained (disabled)
1.68 1.68 1.69
IMG_1592 IMG_1593 IMG_1594

Test Case: New Install

  1. Installed 1.69.153
  2. Confirmed Trackers & Ads Blocking is set to Standard
  3. Confirmed opening Brave Shields on a webpage will show a dropdown for Trackers & Ads Blocking settings
  4. Ensured that changing per site ads blocking setting doesn't override globals
  5. Ensured that global settings apply to new sites being opened.
  6. Ensured that ads are blocked on YouTube and other media sites when Trackers & Ads Blocking is enabled.
  7. Ensured that Shields panel UI for ad-blocking settings has not regressed in different modes.
Example Example Example Light Mode Dark Mode Private Mode
IMG_1595 IMG_1596 IMG_1597 IMG_1599 IMG_1600 IMG_1601

Shield Test Pages

Example Example Example Example Example Example
IMG_1603 2 IMG_1604 2 IMG_1605 2 IMG_1606 2 IMG_1607 2 IMG_1608 2

@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - iPad labels Aug 22, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.5.1 using version 1.69 (153)

Test Case: Migration (standard)

  1. Installed 1.68 (141)
  2. Confirmed Trackers & Ads Blocking is set to Standard by default
  3. Navigated to webpage, open the Shields Panel to confirm that boolean toggle state is ON
  4. Upgraded to 1.69 (153)
  5. Verified Standard setting is retained in global settings
  6. Verified Ads Blocking is set to Standard for the per site in Brave Shields
  7. Verified webpage & embedded video ads are blocked after migration in aggressive mode
  8. Verified changing per site setting
  9. Verified Ads Blocking are showing the correct value in Shields panel in Private mode
1.68 1.69 1.69 Private Mode Media Site 1 Media Site 2
IMG_7095 IMG_7096 IMG_7097 IMG_7098 IMG_7099 IMG_7100

Test Case: Migration (aggressive)

  1. Installed 1.68 (141)
  2. Set Trackers & Ads Blocking to Aggressive mode in Brave Shields & Privacy
  3. Navigated to webpage, open the Shields Panel to confirm that boolean toggle state
  4. Upgraded to 1.69 (153)
  5. Verified Aggressive setting is retained in global settings
  6. Verified Ads Blocking is set to Aggressive for the per site in Brave Shields
  7. Verified webpage & embedded video ads are blocked after migration in aggressive mode
1.68 1.68 1.69 YT
IMG_7102 IMG_7103 IMG_7104 IMG_7105

Test Case: Migration (disabled)

  1. Installed 1.68.141
  2. Set Trackers & Ads Blocking to Disabled mode in Brave Shields & Privacy settings
  3. Navigated to webpage, open the Shields Panel to confirm that boolean toggle state is OFF
  4. Upgraded to 1.69 (153)
  5. Verified Disabled setting is retained in global settings
  6. Verified Ads Blocking is set to Disabled for the per site in Brave Shields
  7. Verified ads are being shown on websites.
1.68 1.69 YT (ads)
IMG_7106 IMG_7107 IMG_7108

Test Case: Migration (Shields down)

  1. Installed 1.68.141
  2. Opened a website
  3. Disabled Shields in the panel
  4. Upgraded to 1.69.153
  5. Confirmed Shields are disabled for the webpage
  6. Confirmed Shields can be enabled after upgrading
  7. Confirmed the Ads Blocking settings have not changed

Test Case: Migration (Per site selection)

  1. Installed 1.68.141
  2. Opened a webpage
  3. Changed global ad-blocking to Aggressive
  4. Disabled ads-blocking in Shields panel for one webpage
  5. Opened another webpage and leave the settings as is but disable fingerprint protection
  6. Upgraded to 1.69.153
  7. Confirmed global ads blocking setting is set to Aggressive
  8. Confirmed ads-blocking is disabled for webpage in step 4
  9. Confirmed that ads-blocking is set aggressive mode for the other site
  10. Confirmed fingerprint protection setting is retained for other site.
1.68 1.69 1.69
IMG_7109 IMG_7110 IMG_7111

Test Case: New Install

  1. Installed 1.69.153
  2. Confirmed Trackers & Ads Blocking is set to Standard
  3. Confirmed opening Brave Shields on a webpage will show a dropdown for Trackers & Ads Blocking settings
  4. Ensured that changing per site ads blocking setting doesn't override globals
  5. Ensured that global settings apply to new sites being opened.
  6. Ensured that ads are blocked on YouTube and other media sites when Trackers & Ads Blocking is enabled.
  7. Ensured that Shields panel UI for ad-blocking settings has not regressed in different modes.
Example Light Mode Dark Mode Private Mode
IMG_7086 IMG_7086 IMG_7087 IMG_7088

Shield Test Pages

Example Example Example Example Example Example
IMG_7089 IMG_7090 IMG_7091 IMG_7092 IMG_7093 IMG_7094

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 23, 2024
@kjozwiak kjozwiak mentioned this issue Sep 4, 2024
Closed
14 tasks
@Uni-verse Uni-verse mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuba cuba

Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Add per site shield level settings brave/brave-core
4 participants
@cuba @ShivanKaul @Uni-verse @brave-builds