Skip to content

[Android] Update button on filters page should update all lists including custom lists #39431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 6 tasks
ShivanKaul opened this issue Jun 27, 2024 · 0 comments
Open
2 of 6 tasks
Assignees
Labels
feature/components feature/settings OS/Android Fixes related to Android browser functionality

Comments

@ShivanKaul
Copy link
Collaborator

Description

We currently don't update the custom filter lists via the Update button introduced in #35270. On Desktop, it's fairly clear that the Update button will update the non-custom-lists (default + additional) because it's tied to that section, but on Android the Update button is at the top and directly above the Custom section.

To summarize the changes:

  1. no changes to the Update button text
  2. we simply start updating the custom filter lists as well
  3. for the text that pops up when you press the button, we say “All lists" instead

Steps to reproduce

On Android, go to Content filters in Settings > Brave Shields & privacy
Try to press the update button

Actual result

Custom lists not updated

Expected result

Custom lists should be updated

Reproduces how often

Easily reproduced

Brave version

1.68

Device

See brave/brave-core#23929

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@ShivanKaul ShivanKaul added feature/settings feature/components OS/Android Fixes related to Android browser functionality labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/components feature/settings OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

2 participants