Skip to content

Add a space between message and Learn more in SPL send token confirmation screen #39159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 6 tasks
srirambv opened this issue Jun 19, 2024 · 1 comment · Fixed by brave/brave-core#24324
Closed
3 of 6 tasks

Add a space between message and Learn more in SPL send token confirmation screen #39159

srirambv opened this issue Jun 19, 2024 · 1 comment · Fixed by brave/brave-core#24324
Assignees
@josheleonard
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Add a space between message and Learn more in SPL send token confirmation screen

Steps to reproduce

  1. Queue a transaction to send a SPL token to an address that has not owned that token before
  2. View warning regarding the account creation fees within the transaction confirmation panel
  3. Learn more doesn't have space after period

Actual result

u9Eee9RzEK

Expected result

Should have a space after the period before Learn more

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.67.119 Chromium: 126.0.6478.114 (Official Build) (64-bit)
Revision 36e2dbd9e397c3a8a4d54a741ea5a6316eab0203
OS Windows 11 Version 23H2 (Build 22631.3737)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @josheleonard
@srirambv srirambv added this to Web3 Jun 19, 2024
@srirambv srirambv mentioned this issue Jun 19, 2024
Closed
@josheleonard josheleonard self-assigned this Jun 21, 2024
@josheleonard josheleonard moved this to In Progress in Web3 Jun 21, 2024
@josheleonard josheleonard mentioned this issue Jun 21, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jun 24, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 24, 2024
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.69.110 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit)
Revision b48482acae2813d6c44e4a83f48b479c56dbc116
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from issue description
  • Verified space is added before Learn more in SPL send token confirmation screen
    image

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): add space before learn-more link brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds