Skip to content

[ads] Clear ads history, conversion URLs, etc when browsing history is cleared #39051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
diracdeltas opened this issue Jun 14, 2024 · 5 comments · Fixed by brave/brave-core#24695
Closed
4 tasks done
Assignees
Labels
feature/ads OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - iPhone QA Pass-Linux QA/Yes release-notes/include

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 14, 2024

Description

If the user goes to brave://settings/clearBrowserData to clear "browsing history" for a given time range, stored ad data associated with that time range should also be cleared since it often includes partial browsing history. Similarly this should happen on exit every time if they have "clear browsing data on exit" set.

Data to be deleted:

  • Default/ads_service/database.sqlite:
  • Default/ads_service/client.json:
  • Default/ads_service/confirmations.json:
  • Default/Preferences/brave/brave_ads:
@diracdeltas diracdeltas added privacy feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jun 14, 2024
@fmarier
Copy link
Member

fmarier commented Jun 14, 2024

Also covered by #38804 and #38959.

@tmancey tmancey added this to Ads Jun 15, 2024
@github-project-automation github-project-automation bot moved this to New issues in Ads Jun 15, 2024
@tmancey tmancey moved this from New issues to To Do in Ads Jun 15, 2024
@tmancey tmancey changed the title clear ads history, conversion URLs, etc when browsing history is cleared [ads] Clear ads history, conversion URLs, etc when browsing history is cleared Jun 15, 2024
@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 20, 2024
@aseren aseren moved this from To Do to In progress in Ads Jun 21, 2024
@aseren aseren moved this from In progress to Review in Ads Jul 27, 2024
@aseren aseren removed the OS/Android Fixes related to Android browser functionality label Aug 5, 2024
@aseren
Copy link

aseren commented Aug 5, 2024

Android will be implemented in #40290

@github-project-automation github-project-automation bot moved this from Review to Done in Ads Aug 8, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Aug 8, 2024
@LaurenWags
Copy link
Member

Per discussion with @btlechowski - removed feature/rewards as this is ads focused, as such he will cover this testing 👍🏻

@btlechowski
Copy link

btlechowski commented Sep 17, 2024

Verified with

Brave 1.70.109 Chromium: 128.0.6613.138 (Official Build) beta (64-bit)
Revision fec4422ae56f4d9680c71a3c1de60b9a8e5ef32f
OS Linux

Verified test plan from brave/brave-core#24695

Test Case 1 - search ad

Triggered search ad and verified served nor view events are not triggered

[11990:11990:0917/124715.258471:VERBOSE1:search_result_ad_event_handler.cc(53)] Search result ad: Not allowed to fire event
[11990:11990:0917/124715.259171:VERBOSE1:search_result_ad_event_handler.cc(227)] Failed to fire search result ad kServedImpression event for placement_id e44bfe11-d65f-40ac-b186-deefc430ed15 and creative instance id c2f2dace-d356-4bce-b5c9-cae75f2bd2aa

Clicked the ad

[44483:44483:0917/205757.123985:VERBOSE3:search_result_ad_handler.cc(185)] Clicked search result ad with placement id 5f20ad50-5c7d-4a94-83b7-25382d348f87 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

converted the ad

[44483:44483:0917/205929.291543:VERBOSE1:ad_handler.cc(129)] Converted click conversion for search_result_ad with creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a, creative set id d04f6627-4b81-45a9-9fae-d01e4a851b93, campaign id 56fc9d5a-5540-46d4-8c10-70573e9d5a3d and advertiser id 5f1ec21a-3526-4504-b0b7-ffe17e8de8bb

Verified ad_events and creative_set_conversions are not empty

image image

Clicked Clear Brave Ads data... link

image image

Verified ads data was cleared:

image image image image

Verified ads_service/client.json and ads_service/confirmations.json are cleared

image image

Test Case 2 - search ad and Brave News ad

[41881:41881:0917/203024.456134:VERBOSE1:search_result_ad_event_handler.cc(53)] Search result ad: Not allowed to fire event
[41881:41881:0917/203024.460020:VERBOSE1:search_result_ad_event_handler.cc(227)] Failed to fire search result ad kServedImpression event for placement_id 4173341f-b69e-4675-bc4b-c686c0d2ec2e and creative instance id c2f2dace-d356-4bce-b5c9-cae75f2bd2aa
[41881:41881:0917/203024.633825:VERBOSE2:tab_manager.cc(159)] Tab id 825142499 HTML content changed

clicked the search ad

[45659:45659:0917/210930.076913:VERBOSE3:search_result_ad_handler.cc(185)] Clicked search result ad with placement id 263c2f10-5e44-4ca5-8b99-cac89f25206a and creative instance id 2207852a-4e8a-493c-8b23-3b5dd83634af

converted the search ad

[45659:45659:0917/211051.140744:VERBOSE1:ad_handler.cc(129)] Converted click conversion for search_result_ad with creative instance id 2207852a-4e8a-493c-8b23-3b5dd83634af, creative set id d04f6627-4b81-45a9-9fae-d01e4a851b93, campaign id 56fc9d5a-5540-46d4-8c10-70573e9d5a3d and advertiser id 5f1ec21a-3526-4504-b0b7-ffe17e8de8bb

viewed the Brave News ad

[41881:41881:0917/203811.132358:VERBOSE3:inline_content_ad_handler.cc(205)] Viewed inline content ad impression with placement id 08ccf3ef-dbd2-43d5-b5fb-265527cc5416 and creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a

click the Brave News ad

[41881:41881:0917/203938.037319:VERBOSE3:inline_content_ad_handler.cc(217)] Clicked inline content ad with placement id 08ccf3ef-dbd2-43d5-b5fb-265527cc5416 and creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a

converted Brave News ad

[41881:41881:0917/204215.811274:VERBOSE1:ad_handler.cc(129)] Converted click conversion for inline_content_ad with creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a, creative set id 8b848823-c47f-43de-a753-2efa8dea6863, campaign id 07de7f05-ab32-4af0-a350-a1bce4427eac and advertiser id 93130af3-2def-4ecb-b836-b3772e73b3c9

Verified ad_events and creative_set_conversions are not empty

image image

Clicked Clear Brave Ads data... link

image image

Verified ads data was cleared:

image image image

Verified creative_set_conversions table doesn't contain row with creative_set_id = d81220f2-b7c6-4f3e-b3fa-5e0f579407a5

image

Verified ads_service/client.json and ads_service/confirmations.json are cleared

image image

Test Case 3 - rewards users

Verified after joining brave rewards, Reset Brave Rewards data... is shown

image

Verified clicking the link opens Reset Rewards

image

Verified successful reset rewards

image image

Update non-rewards users

viewed search ad on 1.69.x

[47817:47817:0917/212213.900064:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward view confirmation for search_result_ad with transaction id b6c1f2f3-fbe0-488e-a4da-e3dd08a20b2e and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

clicked search ad on 1.69.x

[47817:47817:0917/212249.397774:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward click confirmation for search_result_ad with transaction id dde2d45b-1d49-4f08-b692-ce95e1139295 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

landed search ad on 1.69.x

[47817:47817:0917/212328.482739:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward landed confirmation for search_result_ad with transaction id 75f9a099-d8c4-4a13-9fba-e3c56546864a and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

converted search ad on 1.69.x

[47817:47817:0917/212530.059268:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward conversion confirmation for search_result_ad with transaction id 03cd0036-0cd0-4b14-aac3-2ec4b4167216 and creative instance id 788a9319-9ff9-4cf8-944b-98dcdc3dbfa8

viewed Brave News ad on 1.69.x

[47817:47817:0917/212646.870096:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward view confirmation for inline_content_ad with transaction id 2346d131-c347-454e-8e72-75d9ab9d2e32 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

clicked Brave News ad on 1.69.x

[47817:47817:0917/212722.851501:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward click confirmation for inline_content_ad with transaction id 6818eeab-d512-4bf8-a01a-b79b77410d79 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

landed Brave News ad on 1.69.x

[47817:47817:0917/212830.550926:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward landed confirmation for inline_content_ad with transaction id 454a314b-2fee-4878-b08c-f3ac52b33847 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

converted Brave News ad on 1.69.x

[47817:47817:0917/212927.017582:VERBOSE1:redeem_non_reward_confirmation.cc(107)] Successfully redeemed non-reward conversion confirmation for inline_content_ad with transaction id da7a141c-6248-45e9-9197-074ed01cc584 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

1.69.x:

image image
image image

Updated to 1.70.x and cleared the data

Verified ads data was cleared:

image image image

Verified creative_set_conversions table doesn't contain row with creative_set_id = d81220f2-b7c6-4f3e-b3fa-5e0f579407a5
image

Verified ads_service/client.json and ads_service/confirmations.json are cleared

image image

@btlechowski
Copy link

Verification passed on 1.70.126 on iPhone 13 Pro Max (iOS 17.5)

The test cases were refactored due to limited access to Brave files.

Verified test plan from brave/brave-core#24695

Test Case 4 - search ad

Steps:

  1. Trigger a search ad
  2. Click the search ad
  3. Clear ads data
  4. Trigger a conversion

Triggered search ad and verified served nor view events are not triggered

info	04:24:03.852255+0200	Client	[ads] Search result ad: Not allowed to fire event
info	04:24:03.852298+0200	Client	[ads] Failed to fire search result ad kServedImpression event for placement_id 3f30ca06-d70d-4581-9129-aed4ee779aee and creative instance id 788a9319-9ff9-4cf8-944b-98dcdc3dbfa8

Clicked the ad

info	04:24:26.222445+0200	Client	[ads] Clicked search result ad with placement id 3f30ca06-d70d-4581-9129-aed4ee779aee and creative instance id 788a9319-9ff9-4cf8-944b-98dcdc3dbfa8
info	04:24:26.224562+0200	Client	[ads] Successfully saved creative set conversions

Cleared ads data

Image

Verified ads data was cleared by checking conversion does not happen

info	04:26:38.318268+0200	Client	[ads] Checking for creative set conversions
info	04:26:38.320362+0200	Client	[ads] There are no creative set conversions

Also verified that conversions work:

Triggered search ad and verified served nor view events are not triggered

info	03:35:56.992904+0200	Client	[ads] Search result ad: Not allowed to fire event
info	03:35:56.992985+0200	Client	[ads] Failed to fire search result ad kServedImpression event for placement_id 4472bc16-ffdc-40ba-96aa-dcca2c966f0c and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

Clicked the ad

info	03:36:01.499116+0200	Client	[ads] Clicked search result ad with placement id 4472bc16-ffdc-40ba-96aa-dcca2c966f0c and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

Converted the ad

info	04:14:54.491089+0200	Client	[ads] Converted click conversion for search_result_ad with creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a, creative set id d04f6627-4b81-45a9-9fae-d01e4a851b93, campaign id 56fc9d5a-5540-46d4-8c10-70573e9d5a3d and advertiser id 5f1ec21a-3526-4504-b0b7-ffe17e8de8bb
info	04:14:54.491138+0200	Client	[ads] Successfully processed deposit for search_result_ad with creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a and conversion valued at 0
info	04:14:54.491187+0200	Client	[ads] Confirming conversion for search_result_ad with transaction id 742d4bdc-0744-433c-8d3b-6250469a1501 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a
info	04:14:54.491528+0200	Client	[ads] Successfully added conversion confirmation for search_result_ad with transaction id 742d4bdc-0744-433c-8d3b-6250469a1501 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a to the queue
info	04:14:54.492388+0200	Client	[ads] Process conversion confirmation for search_result_ad with transaction id 742d4bdc-0744-433c-8d3b-6250469a1501 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a in 0 hours, 0 minutes, 5 seconds at 04:14:59.490
info	04:14:59.494309+0200	Client	[ads] Redeem non-reward confirmation
info	04:14:59.494405+0200	Client	[ads] Create non-reward confirmation
info	04:14:59.494694+0200	Client	[ads] URL Request:
  URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/742d4bdc-0744-433c-8d3b-6250469a1501
  Content: {"conversion":[{"action":"click"}],"creativeInstanceId":"bc876b1a-ca48-4eac-b445-efb9617ead4a","transactionId":"742d4bdc-0744-433c-8d3b-6250469a1501","type":"conversion"}
  Content Type: application/json
  Method: kPost
info	04:15:00.457398+0200	Client	[ads] URL Response:
  URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/742d4bdc-0744-433c-8d3b-6250469a1501
  Response Status Code: 418
  Response: {"id":"742d4bdc-0744-433c-8d3b-6250469a1501","payload":{},"type":"conversion","createdAt":"2024-10-10T02:15:00.292Z","modifiedAt":"2024-10-10T02:15:00.292Z","creativeInstanceId":"bc876b1a-ca48-4eac-b445-efb9617ead4a"}
info	04:15:00.460567+0200	Client	[ads] Successfully redeemed non-reward conversion confirmation for search_result_ad with transaction id 742d4bdc-0744-433c-8d3b-6250469a1501 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a
info	04:15:00.466336+0200	Client	[ads] Successfully processed conversion confirmation for search_result_ad with transaction id 742d4bdc-0744-433c-8d3b-6250469a1501 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

Test Case 5 - search ad and Brave News ad

info	04:43:45.385905+0200	Client	[ads] Search result ad: Not allowed to fire event
info	04:43:45.385951+0200	Client	[ads] Failed to fire search result ad kServedImpression event for placement_id b87c1e7f-c265-4a45-aeeb-21db28c167c6 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a

clicked the search ad

info	04:44:01.218945+0200	Client	[ads] Clicked search result ad with placement id b87c1e7f-c265-4a45-aeeb-21db28c167c6 and creative instance id bc876b1a-ca48-4eac-b445-efb9617ead4a
info	04:44:01.221151+0200	Client	[ads] Successfully saved creative set conversions

viewed the Brave News ad

info	04:44:46.667129+0200	Client	[ads] Viewed inline content ad impression with placement id e834ae89-1724-4420-a458-afdfa93a032f and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info	04:44:46.667438+0200	Client	[ads] Successfully processed deposit for inline_content_ad with creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 and view valued at 0
info	04:44:46.667517+0200	Client	[ads] Confirming view for inline_content_ad with transaction id 758255b5-fd1d-4302-b155-acbc388f12d2 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info	04:44:46.670530+0200	Client	[ads] Successfully added view confirmation for inline_content_ad with transaction id 758255b5-fd1d-4302-b155-acbc388f12d2 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 to the queue
info	04:44:46.672147+0200	Client	[ads] Process view confirmation for inline_content_ad with transaction id 758255b5-fd1d-4302-b155-acbc388f12d2 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 in 0 hours, 0 minutes, 5 seconds at 04:44:51.670
info	04:44:51.671183+0200	Client	[ads] Redeem non-reward confirmation
info	04:44:51.671427+0200	Client	[ads] Create non-reward confirmation
info	04:44:51.671817+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/758255b5-fd1d-4302-b155-acbc388f12d2
  Content: {"creativeInstanceId":"cbe9f40d-257f-429c-939c-39f3d05a0372","transactionId":"758255b5-fd1d-4302-b155-acbc388f12d2","type":"view"}
  Content Type: application/json
  Method: kPost
info	04:44:52.621334+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/758255b5-fd1d-4302-b155-acbc388f12d2
  Response Status Code: 418
  Response: {"id":"758255b5-fd1d-4302-b155-acbc388f12d2","payload":{},"type":"view","createdAt":"2024-10-10T02:44:52.500Z","modifiedAt":"2024-10-10T02:44:52.500Z","creativeInstanceId":"cbe9f40d-257f-429c-939c-39f3d05a0372"}
info	04:44:52.621617+0200	Client	[ads] Successfully redeemed non-reward view confirmation for inline_content_ad with transaction id 758255b5-fd1d-4302-b155-acbc388f12d2 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info	04:44:52.627763+0200	Client	[ads] Successfully processed view confirmation for inline_content_ad with transaction id 758255b5-fd1d-4302-b155-acbc388f12d2 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372

click the Brave News ad

info	04:45:29.076529+0200	Client	[ads] Clicked inline content ad with placement id e834ae89-1724-4420-a458-afdfa93a032f and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info	04:45:29.076551+0200	Client	[ads] Successfully processed deposit for inline_content_ad with creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 and click valued at 0
info	04:45:29.076575+0200	Client	[ads] Confirming click for inline_content_ad with transaction id e921b48a-7a24-4b0c-844d-558ce88531d6 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info	04:45:29.081167+0200	Client	[ads] Successfully added click confirmation for inline_content_ad with transaction id e921b48a-7a24-4b0c-844d-558ce88531d6 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 to the queue
info	04:45:29.081756+0200	Client	[ads] Process click confirmation for inline_content_ad with transaction id e921b48a-7a24-4b0c-844d-558ce88531d6 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 in 0 hours, 0 minutes, 5 seconds at 04:45:34.081
info	04:45:34.082521+0200	Client	[ads] Redeem non-reward confirmation
info	04:45:34.082644+0200	Client	[ads] Create non-reward confirmation
info	04:45:34.083019+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/e921b48a-7a24-4b0c-844d-558ce88531d6
  Content: {"creativeInstanceId":"cbe9f40d-257f-429c-939c-39f3d05a0372","transactionId":"e921b48a-7a24-4b0c-844d-558ce88531d6","type":"click"}
  Content Type: application/json
  Method: kPost
info	04:45:34.910625+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/e921b48a-7a24-4b0c-844d-558ce88531d6
  Response Status Code: 418
  Response: {"id":"e921b48a-7a24-4b0c-844d-558ce88531d6","payload":{},"type":"click","createdAt":"2024-10-10T02:45:34.743Z","modifiedAt":"2024-10-10T02:45:34.743Z","creativeInstanceId":"cbe9f40d-257f-429c-939c-39f3d05a0372"}
info	04:45:34.910975+0200	Client	[ads] Successfully redeemed non-reward click confirmation for inline_content_ad with transaction id e921b48a-7a24-4b0c-844d-558ce88531d6 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info	04:45:34.917166+0200	Client	[ads] Successfully processed click confirmation for inline_content_ad with transaction id e921b48a-7a24-4b0c-844d-558ce88531d6 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372

Cleared ads data

Verified ads data was cleared by checking conversion does not happen for search ad

info	04:50:52.624757+0200	Client	[ads] Checking for creative set conversions
info	04:50:52.629272+0200	Client	[ads] There are no matching creative set conversions

Verified ads data was cleared by checking conversion does not happen for Brave News inline ad

info	04:51:38.016613+0200	Client	[ads] Checking for creative set conversions
info	04:51:38.018758+0200	Client	[ads] 1 out of 1 matching creative set conversions are sorted into 1 buckets
info	04:51:38.018779+0200	Client	[ads] There were no conversion matches

Also verified that conversions for Brave News inline ads actually work

Also verified that conversions work:

viewed the ad

info	05:14:23.092909+0200	Client	[ads] Viewed inline content ad impression with placement id 39df40f0-ac50-4bc0-8f0a-ae67a09550a6 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8

Clicked the ad

info	05:14:24.813910+0200	Client	[ads] Clicked inline content ad with placement id 39df40f0-ac50-4bc0-8f0a-ae67a09550a6 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8

Converted the ad

info	05:15:16.370518+0200	Client	[ads] Checking for creative set conversions
info	05:15:16.373826+0200	Client	[ads] 2 out of 2 matching creative set conversions are sorted into 2 buckets
info	05:15:16.374902+0200	Client	[ads] Converted click conversion for inline_content_ad with creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8, creative set id 59ae2407-51ae-48f6-9d67-6ae234319181, campaign id 07de7f05-ab32-4af0-a350-a1bce4427eac and advertiser id 93130af3-2def-4ecb-b836-b3772e73b3c9
info	05:15:16.375010+0200	Client	[ads] Successfully processed deposit for inline_content_ad with creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8 and conversion valued at 0
info	05:15:16.375080+0200	Client	[ads] Confirming conversion for inline_content_ad with transaction id d72603d5-1b26-4c15-a517-fac63a4466f0 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8
info	05:15:16.375876+0200	Client	[ads] Successfully added conversion confirmation for inline_content_ad with transaction id d72603d5-1b26-4c15-a517-fac63a4466f0 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8 to the queue
info	05:15:16.375972+0200	Client	[ads] Process conversion confirmation for inline_content_ad with transaction id d72603d5-1b26-4c15-a517-fac63a4466f0 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8 in 0 hours, 0 minutes, 5 seconds at 05:15:21.371
info	05:15:16.407197+0200	Client	Search Backup results are ready but the page has not been loaded yet
info	05:15:21.373405+0200	Client	[ads] Redeem non-reward confirmation
info	05:15:21.373550+0200	Client	[ads] Create non-reward confirmation
info	05:15:21.373893+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/d72603d5-1b26-4c15-a517-fac63a4466f0
  Content: {"conversion":[{"action":"click"}],"creativeInstanceId":"1d87cb97-3f55-4a3d-bce1-1c841f39b6f8","transactionId":"d72603d5-1b26-4c15-a517-fac63a4466f0","type":"conversion"}
  Content Type: application/json
  Method: kPost
info	05:15:22.608084+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/d72603d5-1b26-4c15-a517-fac63a4466f0
  Response Status Code: 418
  Response: {"id":"d72603d5-1b26-4c15-a517-fac63a4466f0","payload":{},"type":"conversion","createdAt":"2024-10-10T03:15:22.344Z","modifiedAt":"2024-10-10T03:15:22.344Z","creativeInstanceId":"1d87cb97-3f55-4a3d-bce1-1c841f39b6f8"}
info	05:15:22.608383+0200	Client	[ads] Successfully redeemed non-reward conversion confirmation for inline_content_ad with transaction id d72603d5-1b26-4c15-a517-fac63a4466f0 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8
info	05:15:22.615537+0200	Client	[ads] Successfully processed conversion confirmation for inline_content_ad with transaction id d72603d5-1b26-4c15-a517-fac63a4466f0 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8

Test Case 6 - rewards users

Verified after joining brave rewards, the toggle is removed from Clear Data

Verified clicking Clear Data does not clear rewards.

Non-rewards rewards
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ads OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - iPhone QA Pass-Linux QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants