-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[ads] Clear ads history, conversion URLs, etc when browsing history is cleared #39051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Android will be implemented in #40290 |
Per discussion with @btlechowski - removed |
Verified with
Verified test plan from brave/brave-core#24695 Test Case 1 - search adTriggered search ad and verified served nor view events are not triggered
Clicked the ad
converted the ad
Verified
Clicked
Verified ads data was cleared:
Verified
Test Case 2 - search ad and Brave News ad
clicked the search ad
converted the search ad
viewed the Brave News ad
click the Brave News ad
converted Brave News ad
Verified
Clicked
Verified ads data was cleared:
Verified Verified
Test Case 3 - rewards usersVerified after joining brave rewards, Verified clicking the link opens Reset Rewards Verified successful reset rewards
Update non-rewards usersviewed search ad on 1.69.x
clicked search ad on 1.69.x
landed search ad on 1.69.x
converted search ad on 1.69.x
viewed Brave News ad on 1.69.x
clicked Brave News ad on 1.69.x
landed Brave News ad on 1.69.x
converted Brave News ad on 1.69.x
1.69.x:
Updated to 1.70.x and cleared the data Verified ads data was cleared:
Verified Verified
|
Verification passed on 1.70.126 on iPhone 13 Pro Max (iOS 17.5) The test cases were refactored due to limited access to Brave files. Verified test plan from brave/brave-core#24695 Test Case 4 - search adSteps:
Triggered search ad and verified served nor view events are not triggered
Clicked the ad
Cleared ads data Verified ads data was cleared by checking conversion does not happen
Also verified that conversions work: Triggered search ad and verified served nor view events are not triggered
Clicked the ad
Converted the ad
Test Case 5 - search ad and Brave News ad
clicked the search ad
viewed the Brave News ad
click the Brave News ad
Cleared ads data Verified ads data was cleared by checking conversion does not happen for search ad
Verified ads data was cleared by checking conversion does not happen for Brave News inline ad
Also verified that conversions for Brave News inline ads actually work Also verified that conversions work: viewed the ad
Clicked the ad
Converted the ad
Test Case 6 - rewards users |
Description
If the user goes to brave://settings/clearBrowserData to clear "browsing history" for a given time range, stored ad data associated with that time range should also be cleared since it often includes partial browsing history. Similarly this should happen on exit every time if they have "clear browsing data on exit" set.
Data to be deleted:
The text was updated successfully, but these errors were encountered: