Skip to content

Allow to stop a streamed Leo response #38337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbondy opened this issue May 15, 2024 · 3 comments · Fixed by brave/brave-core#27238
Closed

Allow to stop a streamed Leo response #38337

bbondy opened this issue May 15, 2024 · 3 comments · Fixed by brave/brave-core#27238
Assignees
Labels
browser-ai design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented May 15, 2024

Currently if you have a question you need to wait for the whole answer.
Sometimes you notice right away after submitting that you forgot to specify something important though and you want to stop the reply early.
The send button should probably change to a stop button for users that want to interrupt a response.

cc @aguscruiz @nullhook @petemill

@bbondy bbondy added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality OS/Desktop browser-ai labels May 15, 2024
@mattmcalister mattmcalister moved this to Backlog in Browser AI May 15, 2024
@mattmcalister mattmcalister added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels May 15, 2024
@aguscruiz aguscruiz self-assigned this May 15, 2024
@aguscruiz
Copy link

aguscruiz commented May 15, 2024

Added designs here:
https://www.figma.com/design/m0Gdbf0wtqyfEFGm32VLLc/Leo?node-id=3496%3A13366&t=CTUxdd31WfqlpazL-1

I also have the iOS version, can you create an issue for that one?

image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.76.55 Chromium: 133.0.6943.54 (Official Build) beta (64-bit)
-- | --
Revision | 8b59c06a32ec3a53b2caada1e6c43c3e5c35d64f
OS | Windows 11 Version 24H2 (Build 26100.2894)
  1. Installed 1.76.55
  2. launched Brave
  3. load a page https://support.brave.com/hc/en-us/articles/26727364100493-What-are-the-differences-between-Leo-s-AI-Models
  4. clicked Leo AI icon in the sidebar
  5. clicked Summarize this page
  6. confirmed Stop button is shown
  7. clicked Stop button
  8. confirmed Leo response was stopped as expected
2025-02-12_16h22_01.mp4

@hffvld
Copy link
Contributor

hffvld commented Feb 18, 2025

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 16 BP22.250103.008 release-keys
Brave build: 1.76.58 
Chromium: 133.0.6943.98 (Official Build) beta (64-bit) 

STEPS:

  1. Launch Brave
  2. Go to https://support.brave.com/hc/en-us/articles/26727364100493-What-are-the-differences-between-Leo-s-AI-Models
  3. Open Leo
  4. Tap Summarize this page > Verify that Stop button is shown
  5. Tap the Stop button > Verify that Leo's response was stopped as expected

ACTUAL RESULTS:

  • Verified that the Stop button is shown when Leo runs the query response.
  • Verified that Leo's response has stopped as expected when tapping the Stop button.

1
1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Status: Done
9 participants