Skip to content

Make Review Button Wider in Wallet Panel #37530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Douglashdaniel opened this issue Apr 11, 2024 · 1 comment · Fixed by brave/brave-core#23045
Closed

Make Review Button Wider in Wallet Panel #37530

Douglashdaniel opened this issue Apr 11, 2024 · 1 comment · Fixed by brave/brave-core#23045
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to allow the Review Button to grow in width in the Wallet Panel

Steps to Reproduce

  1. Open the Wallet Panel and navigate to the Send screen
  2. The Review button should be wider

Actual result:

Screenshot 9

Expected result:

Screenshot 11

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 11, 2024
@Douglashdaniel Douglashdaniel self-assigned this Apr 11, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Apr 11, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Apr 11, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Apr 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 12, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 12, 2024
@srirambv
Copy link
Contributor

srirambv commented May 21, 2024 •
edited
Loading

Verification passed on

Brave 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
Revision d01060f5ec155e6eb64a335203663a29c0e5d81f
OS Windows 11 Version 23H2 (Build 22631.3593)
Enabled Disabled
brave_j777N7LoNM brave_Q0EHC29cE4

@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

style(wallet): Review Button Width in Panel brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds