Click on Brave News (RSS) button should also close dialog

[rebron]

Description

When clicking the Brave News RSS button in the url bar to open, clicking the button again does not close the dialog. Only clicking away closes the dialog. All other buttons e.g. Shields, Rewards, share and notification icons, clicking on the button is open and close of the dialog.

Steps to Reproduce

1. Go to a site that displays the Brave News icon e.g. nytimes.com
2. Click on the Brave News button to open
3. Notice that clicking on the button to close doesn't close it. Only clicking away closes the dialog.

Actual result:

Expected result:

See description

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

[rebron]

cc: @jagadeshjai Is this one something you can help us out with?

[jagadeshjai]

cc: @jagadeshjai Is this one something you can help us out with?

Yes @rebron, I'll look into this.

[Roopasdev]

Hi, I am actually a beginner trying to contribute but I am interested to work on it should I start of with this issue?

[stephendonner]

Verified PASSED using

Brave | 1.69.106 Chromium: 127.0.6533.43 (Official Build) nightly (x86_64)
-- | --
Revision | 2778b12a30fa8f4d7ccd6caad101a7aabcfc6981
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

1. installed 1.69.106
2. launched Brave
3. loaded newsweek.com
4. opened a new-tab page
5. scrolled down
6. clicked on Turn on Brave News
7. returned to the newsweek.com tab
8. clicked on Manage Subscriptions
9. clicked Follow
10. clicked again on the Manage Subscriptions button

Confirmed clicking on the Manage Subscriptions button toggles it open/closed, as it should