Skip to content

Add access to developer menus & logs in release & beta channels #36961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kylehickinson opened this issue Mar 20, 2024 · 4 comments · Fixed by brave/brave-core#22760
Closed

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Mar 20, 2024

Description:

Right now the debug/developer menu in settings is only visible in Nightly channel builds, however now that we are part of the brave-core train there aren't builds that exist in Nightly that may exist in other channels so we need a way to enable logs & other debug related menu options in other channels (possibly behind some sort of password)

AppConstants.buildChannel.isPublic should be removed and code should be replaced so that builds only differ by the OFFICIAL_BUILD conditional compilation flag

@kjozwiak
Copy link
Member

@Uni-verse @hffvld as discussed via https://bravesoftware.slack.com/archives/GAA4017R7/p1711650759653529?thread_ts=1711598803.433469&cid=GAA4017R7, we'll need to verify #37136 as well via this issue to make sure we're getting logs for Leo.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 2, 2024

The above requires 1.64.116 or higher for 1.64.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 12, 2024

Verified on iPhone X running iOS 16.7 using version 1.64 (123)

  • Ensured developer menu prompt is shown when tapping the version header in settings.
  • Ensured that developer/debug menus are displayed when authentication is completed.
  • Ensured that there is no issues accessing logs in debug menu.
  • Ensured that logs are generated when enabling vmodule in BraveCore Switches.
  • Ensured Leo logs are being populated as a required check mentioned in Add Logs to iOS Leo Purchases #37136

Debug menu

Example Example Example Example Example
IMG_3750 2 IMG_3751 5 IMG_3754 5 IMG_3759 3 IMG_3763

Console.app logs (Using Subsystem: com.ios.brave.software)

Screenshot 2024-04-12 at 11 51 19 AM

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 12, 2024

Verified on iPad (7th Gen) running iOS 17.3.1 using version 1.64 (123)

  • Ensured developer menu prompt is shown when tapping the version header in settings.
  • Ensured that developer/debug menus are displayed when authentication is completed.
  • Ensured that there is no issues accessing logs in debug menu.
  • Ensured that logs are generated when enabling vmodule in BraveCore Switches.

Debug menu

Example Example Example Example Example
IMG_1349 IMG_1350 IMG_1351 IMG_1352 IMG_1353

Console.app logs (Using Subsystem: com.ios.brave.software)
Screenshot 2024-04-12 at 12 20 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants