Skip to content

Do not show decimal values for NFT in send screen #36771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Nov 24, 2022 · 2 comments
Closed

Do not show decimal values for NFT in send screen #36771

srirambv opened this issue Nov 24, 2022 · 2 comments
Assignees
@StephenHeaps
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@srirambv
Copy link
Contributor

Description:

Do not show decimal values for NFT in send screen

Steps to Reproduce

  1. Add an NFT to portfolio
  2. Select the token details page and click Send
  3. NFT shows balance in decimals

Actual result:

Ethereum NFT Solana NFT
image image

Expected result:
NFT should not be shown in decimal values

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.45.2 (22.11.23.16)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @nuo-xu @StephenHeaps
@StephenHeaps StephenHeaps self-assigned this Mar 13, 2024
@StephenHeaps StephenHeaps transferred this issue from brave/brave-ios Mar 13, 2024
@StephenHeaps
Copy link

Inadvertently fixed with brave/brave-ios#7576. Please re-test 🙂.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Mar 13, 2024
@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 13, 2024
@StephenHeaps StephenHeaps added this to the 1.64.x - Beta milestone Mar 13, 2024
@srirambv
Copy link
Contributor Author

Verification passed on iPhone 14 with iOS 17.4 running 1.64 (109)

  • Verified steps from issue description
  • Verified NFTs doesn't show any decimal value on Send screen
image image image image image

@kjozwiak kjozwiak mentioned this issue Mar 20, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.64.x - Release
Development

No branches or pull requests
2 participants
@StephenHeaps @srirambv