Skip to content

Bundle filter list catalog with Brave installs #36241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonok-edm opened this issue Feb 20, 2024 · 0 comments · May be fixed by brave/brave-core#22188
Open

Bundle filter list catalog with Brave installs #36241

antonok-edm opened this issue Feb 20, 2024 · 0 comments · May be fixed by brave/brave-core#22188
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Feb 20, 2024

Currently, on first startup of Brave, the browser

  • registers the Brave Ad Block List Catalog component
  • waits for the download to complete
  • registers Brave Ad Block Updater and other default-enabled adblock list components
  • waits for all of those downloads to complete
  • then finally loads filters into the adblock engine

That means adblock cannot work until at least 2 full synchronous network round trips have completed.

We can mitigate this by "preloading" or "bundling" the adblock catalog with the browser installation.

I've confirmed that it is possible to register a branch of a repository as a DEP, so we can directly register brave/adblock-resources@master as a dependency and benefit from the latest version of the catalog in every public build.

This is a step towards the solution mentioned in #35922 (comment).

@antonok-edm antonok-edm added feature/shields/adblock Blocking ads & trackers with Shields perf OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 20, 2024
@antonok-edm antonok-edm self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant