Skip to content

Update to Leo's product header #36202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aguscruiz opened this issue Feb 19, 2024 · 2 comments · Fixed by brave/brave-core#22759
Closed

Update to Leo's product header #36202

aguscruiz opened this issue Feb 19, 2024 · 2 comments · Fixed by brave/brave-core#22759
Assignees
Labels
browser-ai design A design change, especially one which needs input from the design team OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@aguscruiz
Copy link

aguscruiz commented Feb 19, 2024

Description

Changes:

  • Font size changes to 19px with 19px line-height (uses a Nala style that needs to be uploaded called Sidebar product title)
  • The header should have a 60px minimum height. But give the top-bottom paddings a 16px value in case it needs to grow a bit more.
  • Product title is always lowercase
  • Product name changes to "leo ai"
  • Added a "close" icon on the right to close the panel (Desktop and Android)

Design
https://www.figma.com/file/MNwi0uwXNhkAbPiJ86G4vm/%E2%9C%A8-Leo?type=design&node-id=1506%3A7892&mode=design&t=i7noPdyJ4idIyTyS-1

@aguscruiz aguscruiz added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 19, 2024
@aguscruiz aguscruiz added design A design change, especially one which needs input from the design team browser-ai labels Feb 19, 2024
@aguscruiz aguscruiz changed the title Update to Leo Update to Leo's product header Feb 19, 2024
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 15, 2024
@mattmcalister mattmcalister moved this to Important / Polish in Browser AI Mar 15, 2024
@nullhook nullhook moved this from Important / Polish to In Progress in Browser AI Mar 25, 2024
@nullhook nullhook moved this from In Progress to In Review in Browser AI Mar 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Apr 12, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 12, 2024
@stephendonner
Copy link

stephendonner commented Apr 22, 2024

Verification PASSED using

Brave | 1.67.31 Chromium: 124.0.6367.60 (Official Build) nightly (64-bit)
-- | --
Revision | 5d142aa04ae5b4f6447932c461da4cda17db69d9
OS | Windows 10 Version 22H2 (Build 19045.4291)

Confirmed:

  • letter-casing and string change to leo ai from Leo
  • new Close widget with correct tooltip of Close

non-Premium - PASSED

Steps:

  1. installed 1.67.31
  2. launched Brave
  3. loaded vox.com
  4. opened the sidebar
  5. clicked on Summarize
  6. clicked on I understand at the opt-in screen
Dark Light
image image

Premium - PASSED

(continued from non-Premium steps)

Steps:

  1. loaded account.bravesoftware.com
  2. purchased Leo Premium and relaunched with --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. confirmed Leo Premium credentials/badging
Dark Light
image image

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 22, 2024
@Uni-verse
Copy link
Contributor

Verified on on Samsung Galaxy S21 using version:

Brave	1.67.92 Chromium: 125.0.6422.76 (Official Build) beta (64-bit) 
Revision	d751d2edf40b466560aaeecc4c4919041f41c20d
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that product title is always lower case.
  • Ensured badging is correct for free and premium users.
  • Ensured tapping on the X closes Leo chat and tapping on eraser icon will start new conversation.
  • Ensured cog icon will open the Leo main menu.
  • Ensured there are no UI or design issues when upgrading from previous versions with Leo already enabled.
Example Example Example
Screenshot 2024-05-24 at 6 02 27 PM Screenshot 2024-05-24 at 6 02 32 PM Screenshot 2024-05-24 at 5 34 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai design A design change, especially one which needs input from the design team OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants