Skip to content

rewards and brave icon disappearing from URL when pasting/adding text and moving away from URL #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kjozwiak opened this issue Mar 7, 2019 · 3 comments
Labels
bug feature/url-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Mar 7, 2019

Description

When you paste or type something into the omnibox/URL bar, the Rewards/Shield icons will disappear which is expected as the drop down from the omnibox/URL will appear. However, if you click away from the omnibox/URL bar and continue browsing, the text will stay in the omnibox/URL and the Rewards/Shield icons will stay hidden.

Note: This is also reproducible in Chrome so not sure if it's worth fixing. But it's affecting us worse due to having the Shield/BR icon in the URL area.

Steps to Reproduce

  1. launch any version of brave and load brave.com
  2. type something into the URL/omnibox and click somewhere else on the website

You'll notice that you typed is left behind in the URL and both Rewards/Shield icons are not visible.

Actual result:

rewardsbuttondisappearing

Expected result:

If someone moves away from the URL, we should probably revert to the current URL so the Rewards/Shield icons are being displayed again.

Reproduces how often:

100% using the above STR.

Brave version (brave://version info)

Brave 0.62.16 Chromium: 73.0.3683.39 (Official Build) dev(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes, reproducible on all channels.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No

  • Is the issue reproducible on the latest version of Chrome? This is also reproducible in Chrome so not sure if it's worth fixing. But it's affecting us worse due to having the Shield/BR icon in the URL area.

Additional Information

CCing @brave/legacy_qa

@srirambv
Copy link
Contributor

srirambv commented Mar 7, 2019

Might be conflicting with behaviour on #1097

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 12, 2019
@rebron
Copy link
Collaborator

rebron commented Mar 12, 2019

If we get any +1s on this let's revisit.

@bsclifton
Copy link
Member

Per comment by @rebron - at the moment, we have no plans to change this... +1's with desired behavior are welcome, otherwise we can move to a wontfix

When the URL bar is in "edit" mode (you typed into it), the buttons should be hidden, IMO. The reason being: if the buttons DID show- what URL would it correspond to? (the one being edited? or the one you're currently on). Changing this could cause some complexities. The buttons are restored if you hit enter or escape

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P5 Backlog / waiting upstream in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/url-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

4 participants