Skip to content

Update icons in Share menu to use Nala's #35758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aguscruiz opened this issue Feb 1, 2024 · 1 comment · Fixed by brave/brave-core#22875
Closed

Update icons in Share menu to use Nala's #35758

aguscruiz opened this issue Feb 1, 2024 · 1 comment · Fixed by brave/brave-core#22875
Assignees
@zenparsing
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related misc/icons OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@aguscruiz
Copy link

aguscruiz commented Feb 1, 2024 •
edited
Loading

Description

The icons in the share menu are coming straight from Chromium it seems, need to update them.

Design
https://www.figma.com/file/tU9zrk9Ite8B06JSjHAHhn/General-dialogs-and-popups?type=design&node-id=248%3A21458&mode=design&t=jkZK4voDjkVUuQV4-1

Actual result:

image

Expected result:

image
@rebron rebron added misc/icons design A design change, especially one which needs input from the design team polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include labels Feb 1, 2024
@zenparsing zenparsing self-assigned this Feb 1, 2024
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 1, 2024
@stephendonner stephendonner added the feature/user-interface All UI related label Feb 1, 2024
@zenparsing zenparsing mentioned this issue Apr 2, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 11, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 23, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.67.35 Chromium: 124.0.6367.60 (Official Build) nightly (64-bit)
-- | --
Revision | cf6b916e6e68f45b10d6ccebe4530f7319c3d1aa
OS | Windows 11 Version 23H2 (Build 22631.3447)
  1. Installed 1.67.35
  2. launched Brave
  3. load a site (google.com)
  4. click on Share this page icon in the URL bar
  5. confirmed Nala icons are used in Share menu that match to the Figma designs
Dark Theme Light theme
image image

@rebron rebron moved this to Completed in Front End May 28, 2024
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
@rebron rebron removed this from Front End Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related misc/icons OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Use custom icons for sharing hub bubble brave/brave-core
6 participants
@stephendonner @rebron @zenparsing @aguscruiz @brave-builds @MadhaviSeelam