Skip to content

Support better Leo extraction method for GitHub pull requests #35492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bbondy opened this issue Jan 22, 2024 · 4 comments · Fixed by brave/brave-core#22289
Closed

Support better Leo extraction method for GitHub pull requests #35492

bbondy opened this issue Jan 22, 2024 · 4 comments · Fixed by brave/brave-core#22289
Assignees
@bbondy
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include release-notes/social
Milestone
1.65.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 22, 2024 •
edited
Loading

It would be great if Brave Leo could understand pull requests better with custom extraction logic.
This might look like getting a raw diff of the entire changeset and a different pre-prompt.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 22, 2024
@mattmcalister mattmcalister moved this to Todo in Browser AI Jan 31, 2024
@mattmcalister mattmcalister added priority/P4 Planned work. We expect to get to it "soon". browser-ai labels Jan 31, 2024
@bbondy bbondy self-assigned this Feb 23, 2024
@bbondy bbondy moved this from Todo to In Review in Browser AI Feb 23, 2024
@bbondy bbondy mentioned this issue Feb 23, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Feb 27, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 27, 2024
@stephendonner stephendonner changed the title Support better Leo extraction method for Github pull requests Support better Leo extraction method for GitHub pull requests Mar 19, 2024
@stephendonner
Copy link

stephendonner commented Mar 19, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.65.87 Chromium: 123.0.6312.46 (Official Build) beta (64-bit)
-- | --
Revision | 2babfcf82ebba4c5dc0146d2ca66229ffd3ac02d
OS | Windows 10 Version 22H2 (Build 19045.4170)

Steps:

  1. installed 1.65.87
  2. launched Brave
  3. opted in to Leo
  4. loaded https://github.com/brave/brave-core/pull/22801
  5. asked Leo which files were changed

Confirmed 1.65.87 was able to specify the list of filenames which were changed; 1.64.107 was unable to

1.65.87 1.64.107
image image

Additionally:

Which files have the most changes?

Confirmed 1.65.87 was able to specify the top two files with the most changes; 1.64.107 was unable to determine it

1.65.87 1.64.107
image image

@stephendonner
Copy link

stephendonner commented Mar 28, 2024 •
edited
Loading

Verification PASSED using

Brave	1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (x86_64) 
Revision	5d9143e1a0812c53bdc27fd5384591254306a88c
OS	macOS Version 14.4.1 (Build 23E224)

Steps:

  1. installed 1.65.96
  2. launched Brave
  3. opted in to Leo
  4. loaded https://github.com/brave/brave-core/pull/22616
  5. asked Leo which files were changed

Confirmed 1.65.96 was able to specify the list of filenames which were changed; 1.64.107 was unable to

1.65.96 1.64.107
Screenshot 2024-03-28 at 3 55 21 PM Screenshot 2024-03-28 at 4 04 51 PM

Additionally:

Which files have the most changes?

Confirmed 1.65.96 was able to specify the top two files with the most changes; 1.64.107 was unable to determine it

1.65.96 1.64.107
Screenshot 2024-03-28 at 3 57 52 PM Screenshot 2024-03-28 at 4 04 51 PM

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 1, 2024
@stephendonner
Copy link

stephendonner commented Apr 1, 2024 •
edited
Loading

Verification PASSED using

Brave	1.65.100 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	8456ab291d9c823aaff5de460a63b53485320488
OS	Linux

Steps:

  1. installed 1.65.96
  2. launched Brave
  3. opted in to Leo
  4. loaded AIChat: introducing slash tools brave-core#22868
  5. asked Leo which files were changed
  6. asked Leo if -- and if so, which -- files were removed

List of filenames which were changed

1.65.100 1.64.107
Screen Shot 2024-04-01 at 2 01 16 PM Screen Shot 2024-04-01 at 2 12 40 PM

Were any files removed?

1.65.100 1.64.107
Screen Shot 2024-04-01 at 2 01 38 PM Screen Shot 2024-04-01 at 2 12 48 PM

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 1, 2024
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	5d9143e1a0812c53bdc27fd5384591254306a88c
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Scenario:

  1. Load a Github pull request
  2. Enable Leo, ask "which files were changed"
  3. Also ask "which file has the most changes?"
  • Ensured that Leo will provide more details on Github pages.
1.64.x 1.65.x 1.65.x
Screenshot 2024-04-01 at 5 58 59 PM Screenshot 2024-04-01 at 4 15 09 PM Screenshot 2024-04-01 at 4 16 18 PM

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include release-notes/social
Projects
Browser AI
Status: Done
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

Add Github pull request support for Leo brave/brave-core
5 participants
@mattmcalister @stephendonner @bbondy @Uni-verse @brave-builds