Skip to content

Signature verification error throw in wallet standard signTransaction method #34842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yrliou opened this issue Dec 12, 2023 · 3 comments · Fixed by brave/brave-core#21343
Closed

Signature verification error throw in wallet standard signTransaction method #34842

yrliou opened this issue Dec 12, 2023 · 3 comments · Fixed by brave/brave-core#21343
Assignees
@yrliou
Labels
feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
1.61.x - Release #3

Comments

@yrliou
Copy link
Member

yrliou commented Dec 12, 2023 •
edited
Loading

Seeing this error in console when trying to mint https://magiceden.io/launchpad/ryder_one.
This error would be happen when calling signTransaction with partial signed legacy Solana transaction(s).
It is happening for some other NFTs in magic eden launch pad too.
@yrliou yrliou added priority/P2 A bad problem. We might uplift this to the next planned release. webcompat/not-shields-related Sites are breaking because of something other than Shields. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/solana feature/web3/wallet/dapps labels Dec 12, 2023
@yrliou yrliou self-assigned this Dec 12, 2023
@yrliou yrliou added this to Web3 Dec 12, 2023
@yrliou yrliou moved this to In Progress in Web3 Dec 12, 2023
@yrliou
Copy link
Member Author

yrliou commented Dec 12, 2023

wallet standard fix in brave/wallet-standard-brave#39

@yrliou yrliou mentioned this issue Dec 12, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Dec 12, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 12, 2023
This was referenced Dec 12, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.61.104 or higher for 1.61.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.61.104 Chromium: 120.0.6099.115 (Official Build) (64-bit)
Revision 38497f14ca9ff6f1d5b9c1d72f61fec6f0efcf1d
OS Windows 11 Version 23H2 (Build 22631.2715)
  • Verified steps from brave/brave-core#21343
  • Verified able to mint NFT on https://magiceden.io/launchpad/ryder_one, transaction hash
  • Verified able to Sign message using Devnet on https://solana-labs.github.io/wallet-adapter/example/

Verification passed on Google Pixel 8 with Android 14 running 1.61.104 x64 build

  • Verified steps from brave/brave-core#21343
  • Verified able to mint NFT on https://magiceden.io/launchpad/ryder_one, transaction hash
  • Verified able to Sign message using Devnet on https://solana-labs.github.io/wallet-adapter/example/

@LaurenWags LaurenWags mentioned this issue Dec 13, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Web3
Archived in project
Milestone
1.61.x - Release #3
Development

Successfully merging a pull request may close this issue.

Bump wallet standard to fix Signature verification error in signTransaction brave/brave-core
4 participants
@kjozwiak @yrliou @srirambv @brave-builds