Skip to content

Implement countUp animation on Rewards panel and brave://rewards page #34715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Miyayes opened this issue Dec 5, 2023 · 3 comments · Fixed by brave/brave-core#21372
Closed

Implement countUp animation on Rewards panel and brave://rewards page #34715

Miyayes opened this issue Dec 5, 2023 · 3 comments · Fixed by brave/brave-core#21372
Assignees
@zenparsing
Labels
enhancement feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 5, 2023 •
edited
Loading 

### Tasks
- [x] Rewards balance on brave://rewards page
- [x] Rewards balance on Rewards panel

Do not show animation in any case if the value in question is 0.00.

See counter animation here: https://www.youtube.com/watch?v=kqgg5ZQ9mig
@Miyayes Miyayes changed the title Implement counter animation on Rewards balance in Rewards panel and brave://rewards page Implement countUp animation on Rewards balance in Rewards panel and brave://rewards page Dec 5, 2023
@Miyayes Miyayes changed the title Implement countUp animation on Rewards balance in Rewards panel and brave://rewards page Implement countUp animation on Rewards panel and brave://rewards page Dec 5, 2023
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 13, 2023
@Miyayes Miyayes mentioned this issue Dec 13, 2023
Open
@zenparsing zenparsing mentioned this issue Dec 13, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 29, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Mar 20, 2024 •
edited
Loading

Verified with

Brave	1.65.88 Chromium: 123.0.6312.58 (Official Build) beta (x86_64) 
Revision	e260e641e7db9e88b9b51112f4f00febf5a2f5eb
OS	macOS Version 13.6.4 (Build 22G513)

Confirmed "count up" animation on brave://rewards and panel for various custodians.

Uphold - PASSED
Screen.Recording.2024-03-20.at.1.46.58.PM.mov
Gemini - PASSED
Screen.Recording.2024-03-20.at.1.51.16.PM.mov
ZebPay - PASSED
Screen.Recording.2024-03-20.at.1.55.47.PM.mov
bitFlyer - PASSED
Screen.Recording.2024-03-20.at.2.06.00.PM.mov
Self Custody - PASSED
Screen.Recording.2024-03-20.at.2.35.59.PM.mov

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 20, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 26, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.65.93 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
-- | --
Revision | a6eee503125f9441360861f96cfdcccf43b6fee0
OS | Windows 11 Version 23H2 (Build 22631.3296)

Confirmed "count up" animation on brave://rewards and panel for various custodians.

Uphold - PASSED
2024-03-26_13h05_14.mp4
Gemini - PASSED
2024-03-26_13h10_22.mp4
ZebPay - PASSED
Zebpay.mp4
bitFlyer - PASSED
2024-03-26_13h53_51.mp4
Self Custody - Skipped Solana network transaction process was slow when I tried to test this testcase (twice), so skipping at this time.

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 26, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Mar 28, 2024 •
edited
Loading

Verified with

Brave	1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	5d9143e1a0812c53bdc27fd5384591254306a88c
OS	Linux

Confirmed "count up" animation on brave://rewards and panel for various custodians.

Uphold - Skipped

Unable to connect, getting error in logs:

[ RESPONSE ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/0bc574bd-f755-57b3-8464-d297ce891c37/claim
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"message":"error linking wallet: wallet could not be kyc checked: failed to submit transaction: failed to perform api request: Post \"https://api-sandbox.uphold.com/v0/me/cards/f042845f-fa62-4022-8117-a476ec583a7b/transactions\": failed to validate certificate chain: the server certificate was not valid"}
Gemini - PASSED
gemini.mov
ZebPay - PASSED
ZebPay.mov
bitFlyer - PASSED
BitFlyer.mov
Self Custody - PASSED
self-custody.mov

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 29, 2024
@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
enhancement feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

Use a counter animation for Rewards balance displays brave/brave-core
5 participants
@zenparsing @Miyayes @LaurenWags @brave-builds @MadhaviSeelam