Skip to content

[Android] Move youtube related options #34420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
deeppandya opened this issue Nov 17, 2023 · 1 comment · Fixed by brave/brave-core#21043
Closed
2 tasks done

[Android] Move youtube related options #34420

deeppandya opened this issue Nov 17, 2023 · 1 comment · Fixed by brave/brave-core#21043
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@deeppandya
Copy link
Contributor

deeppandya commented Nov 17, 2023 •
edited
Loading

  • Move Block YouTube recommended content to newly created youtube category in Media
  • Move Block YouTube distracting elements to newly created youtube category in Media
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Nov 17, 2023
@tapanmodh tapanmodh mentioned this issue Nov 20, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 22, 2023
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 22, 2023
@hffvld
Copy link
Contributor

hffvld commented Dec 22, 2023

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL / taimen-user  8.1.0 OPM2.171026.006.H1 release-keys
- Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
- Pixel 7 / panther_beta-user 14 AP11.231020.013.A1 release-keys
Brave build: 1.62.114
Chromium: 120.0.6099.115 (Official Build) beta (64-bit)

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings
  3. Brave Shields & privacy > Verify that there is no YouTube section appeared
  4. Go back to Settings > Media > Verify YouTube section with new settings
  5. Enable Block YouTube recommended content and Block YouTube distracting elements
  6. Close the settings and go to https://youtube.com > Verify that new settings are applied correctly

ACTUAL RESULTS:

  • Verified that the whole YouTube section is moved from Brave Shields & privacy to Media
  • Verified that Block YouTube recommended content and Block YouTube distracting elements works as expected
  • Verified with fresh and upgraded profile

Pixel 2 XL / Android 8

Brave Shields & privacy Media Media
1 2 3
Block YouTube recommended content lock YouTube distracting elements lock YouTube recommended content and Block YouTube distracting elements
1 2 3

Galaxy Tab S8 / Android 14

Brave Shields & privacy Media Media
1 2 3
Block YouTube recommended content lock YouTube distracting elements lock YouTube recommended content and Block YouTube distracting elements
1 2 3

Pixel 7 / Android 14

Brave Shields & privacy Media Media
1 2 3
Block YouTube recommended content lock YouTube distracting elements lock YouTube recommended content and Block YouTube distracting elements
1 2 3

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 22, 2023
This was referenced Jan 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Yes release-notes/include
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] move youtube options to media brave/brave-core
3 participants
@deeppandya @brave-builds @hffvld