Skip to content

[Android] Remove cookie consent modal #33151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deeppandya opened this issue Sep 20, 2023 · 2 comments · Fixed by brave/brave-core#20235
Closed

[Android] Remove cookie consent modal #33151

deeppandya opened this issue Sep 20, 2023 · 2 comments · Fixed by brave/brave-core#20235
Assignees

Comments

@deeppandya
Copy link
Contributor

deeppandya commented Sep 20, 2023

With this issue, we need to remove cookie consent modal and all logic from the code.

Test Plan
Plan 1 :

  1. fresh install
  2. go to settings - > Brave Shields & privacy
  3. Block cookie consent notices option should be enabled by default.

Plan 2 :

  1. upgrade an app version
  2. Block cookie consent notices option should respect the change from previous version

Plan 3 :

  1. Verify with https://www.cookieyes.com/blog/gdpr-cookie-consent-banner-examples/ if it respects the option Block cookie consent notices
@kjozwiak
Copy link
Member

The above requires 1.59.100 or higher for 1.59.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 2, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 2, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.59.102
Chromium: 117.0.5938.140 (Official Build) beta (64-bit) 
Revision: 11284b6d5d51252fe1a6fb6b5cba35ef98982357

Fresh install

STEPS:

  1. Fresh install and launch Brave for the first time
  2. Three-dot menu > Settings > Brave Shields & privacy
  3. Scroll down to the Other privacy settings section > Verify
  4. Open https://www.cookieyes.com/blog/gdpr-cookie-consent-banner-examples/ > Verify
  5. Go to the settings and disable the toggle switch for Block cookie consent notices
  6. Open or refresh https://www.cookieyes.com/blog/gdpr-cookie-consent-banner-examples/ if it still opened > Verify
  7. Close and relaunch Brave 5 - 10 times > Verify
  8. Close and relaunch Brave > Go to the Settings > Brave Shields & privacy > Other privacy settings section > Verify

ACTUAL RESULTS:

  • Verified that the Block cookie consent notices toggle switch is shown in the Settings > Brave Shields & privacy > Under Other privacy settings and enabled by default
  • Verified that cookie consent message on the website is not shown when Block cookie consent notices settings is ON
  • Verified that cookie consent message on the website is shown when Block cookie consent notices settings is OFF
  • Verified that the cookie consent notice is not shown
  • Verified that the Block cookie consent notices toggle switch is not removed and respects its previous position after Brave relaunch

English. Dark Mode English. Light Mode Russian German
1 2 3 4
Hebrew Japanise French Spanish
1 2 3 4
2023-10-02_12-43-36.mp4
Upgrade install

STEPS:

  1. Install build 1.59.99 and launch Brave
  2. Three-dot menu > Settings > Brave Shields & privacy
  3. Scroll down to the Other privacy settings section
  4. Find Block cookie consent notices toggle switch` > Disable it
  5. Upgrade Brave to the build 1.59.102 and launch it
  6. Go to the settings and find Block cookie consent notices toggle switch` > Verify
  7. Uninstall Brave and repeat Steps 1 - 6, but this time keep the toggle enabled > Verify

ACTUAL RESULTS:

  • Verified that Block cookie consent notices toggle switch is shown in the Settings > Brave Shields & privacy > Under Other privacy settings after upgrade
  • Verified that the Block cookie consent notices toggle switch respects its previous position after the Brave upgrade

2023-10-02_13-29-29.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants