Skip to content

NFT Spam title showing '0' suffix when no NFTs marked as spam #32984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StephenHeaps opened this issue Sep 13, 2023 · 4 comments · Fixed by brave/brave-core#20204
Closed

NFT Spam title showing '0' suffix when no NFTs marked as spam #32984

StephenHeaps opened this issue Sep 13, 2023 · 4 comments · Fixed by brave/brave-core#20204
Assignees
@muliswilliam
Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.59.x - Release

Comments

@StephenHeaps
Copy link

Description

When a user has no NFTs marked as spam, the NFT section title for spam displays Spam0 instead of Spam / Spam [0].

Steps to Reproduce

  1. Open Portfolio & tap NFT section
  2. Have no NFTs marked as spam
  3. Spam0 shown as title for spam section instead of Spam

Actual result:

Spam0

Expected result:

Just Spam title

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.60.14 Chromium: 117.0.5938.48 (Official Build) nightly (arm64)

Version/Channel Information:

Version 1.60.14 Chromium: 117.0.5938.48 (Official Build) nightly (arm64)

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

When NFTs are marked as spam, the count is shown as expected:
Spam 1
@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/nft labels Sep 13, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Sep 15, 2023
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Sep 15, 2023
@muliswilliam muliswilliam mentioned this issue Sep 19, 2023
Merged
25 tasks
@muliswilliam
Copy link

This will be fixed in the new design. Implemented in this PR: brave/brave-core#20204

@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Sep 19, 2023
@muliswilliam muliswilliam mentioned this issue Sep 26, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

Closing as brave/brave-core#20204 was merged into master.

@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Sep 26, 2023
@kjozwiak kjozwiak added this to the 1.60.x - Nightly milestone Sep 26, 2023
@kjozwiak
Copy link
Member

The above requires 1.59.104 or higher for 1.59.x verification 👍

@kjozwiak kjozwiak added the QA/Yes label Oct 2, 2023
@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2023

Verified as part of #33095 (comment)

@LaurenWags LaurenWags mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Implement NFT management v2 brave/brave-core
6 participants
@kjozwiak @StephenHeaps @HEagle18 @srirambv @brave-builds @muliswilliam