Skip to content

[Android] Implement brave://rewards portion of "giftbox" Rewards onboarding #31592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Miyayes opened this issue Jul 12, 2023 · 0 comments · Fixed by brave/brave-core#19523
Closed

[Android] Implement brave://rewards portion of "giftbox" Rewards onboarding #31592

Miyayes opened this issue Jul 12, 2023 · 0 comments · Fixed by brave/brave-core#19523
Assignees
@zenparsing
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.58.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 12, 2023 •
edited
Loading

Description

Followup to implement brave://rewards page portion while Rewards is not enabled. QA/No since we can just QA this as part of the main onboarding issue.

Solution

Instead of showing the "Start using Brave Rewards" button, we show text (unclickable) instead that just says: "Press the BAT icon in the URL bar to start".

cc: @deeppandya @mkarolin
@Miyayes Miyayes added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No OS/Android Fixes related to Android browser functionality labels Jul 12, 2023
@Miyayes Miyayes mentioned this issue Jul 12, 2023
Closed
@zenparsing zenparsing mentioned this issue Aug 1, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Aug 2, 2023
@Miyayes Miyayes mentioned this issue Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Show onboarding message on Android Rewards page brave/brave-core
4 participants
@zenparsing @Miyayes @sujitacharya2005 @brave-builds