Skip to content

https://github.com/ipfs/boxo shows IPFS badge/icon in the URL bar #31562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #31557
srirambv opened this issue Jul 11, 2023 · 2 comments
Closed
Tracked by #31557

https://github.com/ipfs/boxo shows IPFS badge/icon in the URL bar #31562

srirambv opened this issue Jul 11, 2023 · 2 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 11, 2023

Description

https://github.com/ipfs/boxo shows IPFS badge/icon in the URL bar

Steps to Reproduce

  1. Visit https://github.com/ipfs/boxo
  2. URL bar shows IPFS badge

Actual result:

image

Expected result:

No IPFS badge when there is no valid CID link

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.57.1 Chromium: 115.0.5790.56 (Official Build) beta (64-bit)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS Windows 11 Version 22H2 (Build 22621.1848)
Node info
Version: kubo/0.21.0/brave
Brave IPFS Client Updater (Windows): 1.0.106

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4 @lidel

@srirambv srirambv changed the title Verify https://github.com/ipfs/boxo shows no IPFS badge/icon in the URL bar (ipfs/boxoboxo is not a valid CID → not IPFS resource → no purple button) https://github.com/ipfs/boxo shows IPFS badge/icon in the URL bar Jul 11, 2023
@lidel
Copy link

lidel commented Jul 20, 2023

@srirambv iiuc this is a duplicate of #31145 – maybe bump in priority?

@srirambv
Copy link
Contributor Author

Yup. Closing it as dupe of #31145 and adding a P3 label for #31145

@srirambv srirambv closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2023
@srirambv srirambv added the closed/duplicate Issue has already been reported label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants