Skip to content

Conversion Envelop is not attached when there are other confirmations in the queue #31011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue Jun 13, 2023 · 1 comment · Fixed by brave/brave-core#19179
Closed

Conversion Envelop is not attached when there are other confirmations in the queue #31011

btlechowski opened this issue Jun 13, 2023 · 1 comment · Fixed by brave/brave-core#19179
Assignees
@tmancey
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

Follow up to #31003

Note: conversion envelop is attached when confirmation queue is empty

Steps to Reproduce

  1. Clean profile
  2. Overwrite catalog so that only ad with conversion is there
  3. Enable rewards and ads
  4. Trigger the ad
  5. Dismiss the ad and immediately after
  6. Trigger the conversion
  7. Close Brave
  8. Move clock forward 24h
  9. Run Brave
  10. Wait for the confirmation for the conversion

Actual result:

conversion envelop is not attached

image

Expected result:

conversion envelop is attached

Reproduces how often:

Easily reproduced

Desktop Brave version:

Brave 1.52.125 Chromium: 114.0.5735.110 (Official Build) (64-bit)
Revision 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS Ubuntu 18.04 LTS

cc @tmancey @aseren @iambrianfung
@tmancey tmancey self-assigned this Jun 13, 2023
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 13, 2023
@tmancey
Copy link
Contributor

tmancey commented Jun 28, 2023

Closing as resolved by #23308

@tmancey tmancey closed this as completed Jun 28, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jun 28, 2023
@tmancey tmancey mentioned this issue Jul 10, 2023
Merged
25 tasks
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple Brave Ads conversions and resolve #16090 and #26834 brave/brave-core
2 participants
@tmancey @btlechowski