Skip to content

Adding NFT from a different network just closes the add dialog instead of disabling it #30273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srirambv opened this issue May 11, 2023 · 0 comments
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Adding NFT from a different network just closes the add dialog instead of disabling it

Steps to reproduce

  1. Set Network to Ethereum
  2. Add an Ethereum NFT
  3. Try to add a Polygon NFT in the same network
  4. Add dialog closes but doesn't add the NFT
  5. Change network to Polygon, no NFT is added

Actual result

Adding NFT from a different network just closes the add dialog instead of disabling it

Expected result

Should probably throw error if its not added

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.52.92

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @simoarpe @kleantzogu @jamesmudgett

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 11, 2023
@srirambv srirambv added this to Web3 May 11, 2023
@HEagle18 HEagle18 added front-end-change This task is a front end task and doesn't need any C++ changes priority/P4 Planned work. We expect to get to it "soon". labels Jun 2, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Status: Backlog
Development

No branches or pull requests

2 participants