Skip to content

Show all assets under account details #30251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue May 10, 2023 · 1 comment · Fixed by brave/brave-core#19039
Closed

Show all assets under account details #30251

srirambv opened this issue May 10, 2023 · 1 comment · Fixed by brave/brave-core#19039
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Show all assets under account details and disable extra clicks

Steps to reproduce

  1. Set default network on Buy/Send screen
  2. Go back to portfolio
  3. Select a token from a different network
  4. Select account from the token details page
  5. Shows only tokens tied to the selected network rather than showing all the assets under that account

Actual result

Tokens.details.mp4

Expected result

Should list all tokens for the account rather than the ones for the selected network

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.52.92

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Related to #29552
cc: @Pavneet-Sing @simoarpe

@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 10, 2023
@srirambv srirambv added this to Web3 May 10, 2023
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label May 12, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 May 12, 2023
@Pavneet-Sing Pavneet-Sing changed the title Show all assets under account details and disable extra clicks Show all assets under account details Jun 26, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 26, 2023
@Pavneet-Sing Pavneet-Sing moved this from Backlog to In Review in Web3 Jun 26, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 27, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 27, 2023
@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified steps from issue description
  • Verified all assets under an account is shown as expected
30251.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants