Skip to content

[Leo Icons]: Update permission icons #30189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fallaciousreasoning opened this issue May 7, 2023 · 4 comments · Fixed by brave/brave-core#18688
Closed

[Leo Icons]: Update permission icons #30189

fallaciousreasoning opened this issue May 7, 2023 · 4 comments · Fixed by brave/brave-core#18688

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented May 7, 2023

Subissue of #30092 for updating permission icons (i.e. camera/microphone ect)

@aguscruiz there are a bunch of permission icons we probably want to update too - for example, have a look at any site in brave://settings/content/all (most of these can be shown in the toolbar)

Chromium Icons
image

Leo Icons
image

Note: This issue only relates to the icons on the site settings page, not the ones which show up in the toolbar.

@aguscruiz
Copy link

Listing them here by name in order:

  • autoplay-on
  • user
  • ethereum-on
  • solana-on
  • location-on
  • video-camera
  • microphone
  • motion-sensor
  • notification
  • code
  • image
  • launch
  • sync
  • volume-on
  • download
  • media-visualizer
  • usb
  • cpu-chip
  • file-edit
  • sparkles
  • copy
  • credit-card
  • bluetooth
  • warning-triangle-outline
  • smartphone-hand
  • virtual-reality
  • windows-open

@stephendonner
Copy link

stephendonner commented Jul 1, 2023

Verified PASSED using

Brave 1.54.85 Chromium: 115.0.5790.56 (Official Build) beta (64-bit)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS Windows 10 Version 22H2 (Build 19045.3155)

Confirmed the new icon set in brave://settings/content/all for any given site

1.54.85 Light mode 1.52.129
image (6) image image (5)

@stephendonner
Copy link

stephendonner commented Jul 1, 2023

Verified PASSED using

Brave 1.54.85 Chromium: 115.0.5790.56 (Official Build) beta (x86_64)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS macOS Version 11.7.8 (Build 20G1351)

Confirmed the new icon set in brave://settings/content/all for any given site

1.54.85 Light mode 1.52.129
Screen Shot 2023-07-01 at 3 57 16 PM Screen Shot 2023-07-01 at 4 12 33 PM Screen Shot 2023-07-01 at 3 58 33 PM

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 3, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 3, 2023

Verification PASSED on

Brave	1.57.33 Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision	86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc
OS	Linux

Confirmed the new icon set in brave://settings/content/all for any given site

Light mode Dark mode
image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment