Skip to content

Update NFT auto-discovery modal text #29792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
muliswilliam opened this issue Apr 17, 2023 · 1 comment · Fixed by brave/brave-core#18106
Closed

Update NFT auto-discovery modal text #29792

muliswilliam opened this issue Apr 17, 2023 · 1 comment · Fixed by brave/brave-core#18106
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Apr 17, 2023 •
edited
Loading

Update NFT auto-discovery modal text to:

"Brave Wallet can use a third-party service to automatically display your NFTs. Brave will share your wallet addresses with SimpleHash to provide this service. Learn more."
@muliswilliam muliswilliam converted this from a draft issue Apr 17, 2023
@muliswilliam muliswilliam self-assigned this Apr 17, 2023
@muliswilliam muliswilliam mentioned this issue Apr 17, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 17, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 17, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.100 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Windows 11 Version 22H2 (Build 22621.1702)
  • Verified steps from brave/brave-core#18106
  • Verified NFT auto-discovery text is updated as per test plan
  • Verified Learn more loads the github wiki page for NFT
29792.mp4

@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Update NFT auto-discovery modal text brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam