Skip to content

NFT discovery setting is not respected #29575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nvonpentz opened this issue Apr 7, 2023 · 2 comments · Fixed by brave/brave-core#17960
Closed

NFT discovery setting is not respected #29575

nvonpentz opened this issue Apr 7, 2023 · 2 comments · Fixed by brave/brave-core#17960
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@nvonpentz
Copy link

No description provided.

@nvonpentz nvonpentz added this to Web3 Apr 7, 2023
@nvonpentz nvonpentz mentioned this issue Apr 7, 2023
Merged
25 tasks
@nvonpentz nvonpentz added this to the 1.52.x - Nightly milestone Apr 7, 2023
@nvonpentz nvonpentz moved this to Done in Web3 Apr 7, 2023
@kjozwiak kjozwiak mentioned this issue Apr 12, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.51.87 or higher for 1.51.x verification 👍

@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
@srirambv
Copy link
Contributor

srirambv commented May 2, 2023

Verification passed on

Brave 1.51.109 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1555)
  • Verified steps from brave/brave-core#17960
  • Verified restoring wallet with NFT isn't automatically discovered and added to visible list
29585.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Add missing return statement when NFT discovery disabled brave/brave-core
4 participants
@kjozwiak @nvonpentz @srirambv @brave-builds