Skip to content

NFTs with null symbols are not autodiscovered #29386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nvonpentz opened this issue Mar 29, 2023 · 0 comments · Fixed by brave/brave-core#17818
Closed

NFTs with null symbols are not autodiscovered #29386

nvonpentz opened this issue Mar 29, 2023 · 0 comments · Fixed by brave/brave-core#17818
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/include
Milestone
1.52.x - Release

Comments

@nvonpentz
Copy link

See thread https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1680024794965019, we are treating symbols as required fields, however they are technically optional for both Ethereum and Solana NFTs. When the SimpleHash NFT discovery response includes a null symbol, let's save it as an empty string and add the token instead of not adding the token.
@nvonpentz nvonpentz self-assigned this Mar 29, 2023
@nvonpentz nvonpentz added this to Web3 Mar 29, 2023
@nvonpentz nvonpentz moved this to In Progress in Web3 Mar 29, 2023
@nvonpentz nvonpentz mentioned this issue Mar 29, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Apr 3, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 3, 2023
@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Assign empty string to NFT symbol if symbol returned by SimpleHash is null brave/brave-core
2 participants
@nvonpentz @brave-builds