Skip to content

Support NFT discovery for ERC1155s #29304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nvonpentz opened this issue Mar 24, 2023 · 1 comment · Fixed by brave/brave-core#17778
Open

Support NFT discovery for ERC1155s #29304

nvonpentz opened this issue Mar 24, 2023 · 1 comment · Fixed by brave/brave-core#17778
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/include

Comments

@nvonpentz
Copy link

NFT discovery support was added in brave/brave-core#17332, but ERC1155 support was not included. We need to add this to the SimpleHash parsing.
@nvonpentz nvonpentz added this to Web3 Mar 24, 2023
This was referenced Mar 24, 2023
Open
Merged
@github-project-automation github-project-automation bot moved this to Done in Web3 Mar 27, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 27, 2023
@yrliou
Copy link
Member

yrliou commented Mar 29, 2023

Reverted by brave/brave-core#17812 as UI end doesn't have proper support to get balance and transfer these tokens yet, UI needs updates for calling the right APIs for ERC1155 case.

@yrliou yrliou reopened this Mar 29, 2023
@kjozwiak kjozwiak moved this from Done to In Progress in Web3 Mar 29, 2023
@kjozwiak kjozwiak removed this from the 1.51.x - Beta milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/include
Projects
Web3
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ERC1155 support to NFT discovery brave/brave-core
5 participants
@kjozwiak @yrliou @nvonpentz @srirambv @brave-builds