Skip to content

Default-browser checkmarks are missing for Chrome Dev and Chrome Beta during import #29275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephendonner opened this issue Mar 23, 2023 · 7 comments · Fixed by brave/brave-core#17743

Comments

@stephendonner
Copy link

Description

Default-browser checkmarks are missing for Google Chrome Dev and Google Chrome Beta during import

NOTE: Spun off from #29095, which was spun off from #28717

Steps to Reproduce

  1. install Google Chrome Dev and Google Chrome Beta
  2. launch and populate them with bookmarks, browsing session/history, etc.
  3. set one of the above as the default browser in Apple menu --> System Preferences --> General
  4. install Brave 1.51.56
  5. launch it
  6. click Skip on the 1st page
  7. on the next page, look for Google Chrome Dev or Google Chrome Beta
  8. see if it has a checkmark

Actual result:

Missing its checkmark

225424570-5ae1777f-f2e9-4915-af73-fc7ad2a6e2e2

Expected result:

Has a checkmark, indicating it's the currently default browser

Google Chrome Dev Google Chrome Beta
Screen Shot 2023-03-23 at 10 20 13 AM Screen Shot 2023-03-23 at 10 23 55 AM

Google Chrome Dev

[29519:259:0323/104128.106481:ERROR:welcome_dom_handler.cc(131)] OnGetDefaultBrowsername:Google Chrome Dev.app
[29519:259:0323/104128.106528:ERROR:welcome_dom_handler.cc(138)] OnGetDefaultBrowserbrowser_name:Google Chrome Dev
[29519:259:0323/104128.106547:ERROR:welcome_dom_handler.cc(141)] OnGetDefaultBrowserdefault_browser_name_:Google Chrome Dev

Google Chrome Beta

[29404:259:0323/102332.606932:ERROR:welcome_dom_handler.cc(131)] OnGetDefaultBrowsername:Google Chrome Beta.app
[29404:259:0323/102332.606984:ERROR:welcome_dom_handler.cc(135)] OnGetDefaultBrowserbrowser_name:Google Chrome Beta
[29404:259:0323/102332.606994:ERROR:welcome_dom_handler.cc(141)] OnGetDefaultBrowserdefault_browser_name_:Google Chrome Beta

Reproduces how often:

100%

Brave version (brave://version info)

/cc @LaurenWags

Brave 1.51.56 Chromium: 112.0.5615.29 (Official Build) nightly (x86_64)
Revision 8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS macOS Version 11.7.4 (Build 20G1120)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

cc @LaurenWags @spylogsster @rebron

@stephendonner
Copy link
Author

Also, Chrome stable:

Screen Shot 2023-03-23 at 10 47 37 AM

Google Chrome:

[29624:259:0323/104715.550199:ERROR:welcome_dom_handler.cc(131)] OnGetDefaultBrowsername:Google Chrome.app
[29624:259:0323/104715.550242:ERROR:welcome_dom_handler.cc(141)] OnGetDefaultBrowserdefault_browser_name_:Google Chrome.app

@stephendonner
Copy link
Author

Screen Shot 2023-03-23 at 10 54 14 AM

Chrome Canary:

[29702:259:0323/105323.848949:ERROR:welcome_dom_handler.cc(131)] OnGetDefaultBrowsername:Google Chrome Canary.app
[29702:259:0323/105323.848986:ERROR:welcome_dom_handler.cc(141)] OnGetDefaultBrowserdefault_browser_name_:Google Chrome Canary.app

@spylogsster spylogsster self-assigned this Mar 23, 2023
@stephendonner
Copy link
Author

stephendonner commented Mar 23, 2023

From Ventura 13.3:

Google Chrome Dev

Screenshot 2023-03-23 at 2 46 50 PM

Google Chrome Beta

Screenshot 2023-03-23 at 2 47 21 PM

@stephendonner
Copy link
Author

stephendonner commented Apr 3, 2023

Verification PASSED using Big Sur

Brave 1.51.76 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

Steps:

  1. installed Google Chrome Dev and Google Chrome Beta
  2. launched and populated them with bookmarks, browsing session/history, etc.
  3. set one of the above as the default browser in Apple menu --> System Preferences --> General
  4. install Brave 1.51.576
  5. launch it
  6. click Skip on the 1st page
  7. on the next page, look for Google Chrome Dev or Google Chrome Beta
  8. see if it has a checkmark

Confirmed the default-browser checkmark is applied to the appropriate, default browser

Google Chrome Beta

Google Chrome Beta default brave://welcome
Screen Shot 2023-04-03 at 12 43 58 PM Screen Shot 2023-04-03 at 12 45 04 PM

Google Chrome Dev

Google Chrome Dev default brave://welcome
Screen Shot 2023-04-03 at 12 44 04 PM Screen Shot 2023-04-03 at 12 45 53 PM

@stephendonner
Copy link
Author

Verification PASSED on Ventura

Brave 1.51.76 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.4 (Build 22F5027f)

Steps:

  1. installed Google Chrome Dev and Google Chrome Beta
  2. launched and populated them with bookmarks, browsing session/history, etc.
  3. set one of the above as the default browser in Apple menu --> System Preferences --> General
  4. installed Brave 1.51.76
  5. launched it
  6. clicked Skip on the 1st page
  7. on the next page, look for Google Chrome Dev or Google Chrome Beta
  8. see if it has a checkmark

Confirmed the default-browser checkmark is applied to the appropriate, default browser

Google Chrome Beta

Google Chrome Beta default brave://welcome
Screenshot 2023-04-03 at 1 19 30 PM Screenshot 2023-04-03 at 1 24 54 PM

Google Chrome Dev

Google Chrome Dev default brave://welcome
Screenshot 2023-04-03 at 1 19 36 PM Screenshot 2023-04-03 at 1 20 58 PM

@btlechowski
Copy link

Each platform handles the import differently. Added QA/Test-All-Platforms

@LaurenWags
Copy link
Member

Removed QA/Test-All-Platforms as this was originally working on Win and Linux per the original issue (#28717) but was not working on macOS. This is the follow up issue for macOS. Added OS/macOS label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment