Skip to content

Wallet on ramp providers for native assets #29248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergeyZhukovsky opened this issue Mar 22, 2023 · 2 comments · Fixed by brave/brave-core#17713
Closed

Wallet on ramp providers for native assets #29248

SergeyZhukovsky opened this issue Mar 22, 2023 · 2 comments · Fixed by brave/brave-core#17713
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

Description

We currently allow to buy native network assets even though on ramp provider doesn't support it.

Steps to reproduce

  1. Set a locale to US so Sardine provider could be seen.
  2. Create a wallet and go to a Buy flow.
  3. Pick a Binance Smart Chain Mainnet and BNB as an asset to buy.
  4. Press Buy button.

Actual result

Observe Ramp.Network, Sardine and Transak there.
Screenshot_20230321_144408

Expected result

Only Ramp.Network and Transak should be there as you can't buy BNB via Sardine.

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.51.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above requires 1.50.106 or higher for 1.50.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.50.107 x64 beta build

  • Verified steps from issue description
  • Verified Sardine is not shown for Binance Smart Chain and only shows Ramp.network and Transak
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
29248-ARM.mp4
29248-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants