Skip to content

Updating NFT details doesn't update the image and doesn't show image in details page #29199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Mar 21, 2023 · 3 comments · Fixed by brave/brave-core#24780
Assignees
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Updating NFT details doesn't update the image and doesn't show image in details page

Steps to Reproduce

  1. Add this NFT to portfolio
  2. Ensure it shows the correct image
  3. Edit the NFT and update the Token ID to 2587
  4. Ensure it updates the image correctly
  5. Edit the NFT again and update the contract address to 0x282bdd42f4eb70e7a9d9f40c8fea0825b7f68c5d and token id to 500 which doesn't have any transactions
  6. NFT Image continues to show for Invisible Friends added in steps 1 but the name shows for V1 Cryptopunks (Wrapped)
  7. Click on the NFT icon to load details page, shows error

Actual result:

Invalid.NFT.Token.ID.mp4

Expected result:

Show placeholder image instead of showing existing NFT image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.50.94 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Most likely but not checked

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam @minkyeongshin @kleantzogu @jamesmudgett

@srirambv srirambv added this to Web3 Mar 21, 2023
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 24, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Mar 24, 2023
@josheleonard
Copy link

It seems like token id 500 is not a valid punk. Looks like the token ids start at 1000 https://v1punks.io/token/ETHEREUM:0x282bdd42f4eb70e7a9d9f40c8fea0825b7f68c5d:500

@kjozwiak
Copy link
Member

The above requires 1.69.123 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.69.124 Chromium: 127.0.6533.73 (Official Build) beta (64-bit)
Revision dbc9035349f74e493f3293d93f4cbf35c597dfec
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from issue description
  • Verified NFT details and image update when a different contract address is added to an existing NFT
  • Encountered #40028
29199.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants