Skip to content

Remove Celo from preloaded networks #29162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
onyb opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#17667
Closed

Remove Celo from preloaded networks #29162

onyb opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#17667
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@onyb
Copy link
Member

onyb commented Mar 20, 2023 •
edited
Loading

We've had negligible activity on Celo for a while, so remove it from the list of preloaded networks. Users should still be able to add Celo network from Web3 settings.

Test plan

  1. Celo network is no longer a preloaded network
  2. If Celo is manually added as a network, then the assets belonging to the Celo network can be seen in Swap/Buy/Sell.
@onyb onyb self-assigned this Mar 20, 2023
@onyb onyb added this to Web3 Mar 20, 2023
@onyb onyb moved this to In Review in Web3 Mar 20, 2023
@onyb onyb mentioned this issue Mar 20, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 22, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 22, 2023
@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
@srirambv
Copy link
Contributor

srirambv commented May 2, 2023

Verification passed on

Brave 1.51.109 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from issue description
  • Verified Celo network is removed from pre-loaded network list on a clean profile
  • Verified Celo network is not retained on an upgraded profile in a wallet that is already created and token balance is available
  • Verified Celo network when added as a custom network shows token for Buy/Sell/Swap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Update preloaded networks and optimise network logos brave/brave-core
3 participants
@onyb @srirambv @brave-builds