Skip to content

Account icons are squished when account names is usually long #29129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Mar 17, 2023 · 2 comments · Fixed by brave/brave-core#17733
Closed

Account icons are squished when account names is usually long #29129

srirambv opened this issue Mar 17, 2023 · 2 comments · Fixed by brave/brave-core#17733
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Account icons are squished when account names is usually long

Steps to Reproduce

  1. Add a really long name for an account
  2. Select Account dropdown in portfolio
  3. Icon are squished

Actual result:

image

Expected result:

Should show proper icons

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel
@srirambv srirambv added this to Web3 Mar 17, 2023
@Douglashdaniel Douglashdaniel self-assigned this Mar 17, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 17, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 17, 2023
@vaibhavtevatia

This comment was marked as outdated.

Sign in to view
@Douglashdaniel Douglashdaniel mentioned this issue Mar 23, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 23, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 23, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 23, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Linux
  • Verified steps from brave/brave-core#17733
  • Verified account icon is not squished when the account name is unusually long
    image

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17733
  • Verified account icon is not squished when the account name is unusually long
    brave_TXt7M5r6On

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (arm64)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17733
  • Verified account icon is not squished when the account name is unusually long
    image

@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Long Account Names in Filter brave/brave-core
4 participants
@srirambv @Douglashdaniel @brave-builds @vaibhavtevatia