Skip to content

Token List in Panel needs alignment #29038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Douglashdaniel opened this issue Mar 13, 2023 · 1 comment · Fixed by brave/brave-core#17586
Closed

Token List in Panel needs alignment #29038

Douglashdaniel opened this issue Mar 13, 2023 · 1 comment · Fixed by brave/brave-core#17586
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Mar 13, 2023

Description

The Token list in the Wallet Panel needs text alignment.

Steps to Reproduce

  1. Open the panel and click on View Account Assets
  2. The text alignments for Name and Symbol needs to be aligned left
  3. The text alignment for Balances needs to be aligned `right

Actual result:

Screenshot 9

Expected result:

Screenshot 10

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 13, 2023
@Douglashdaniel Douglashdaniel self-assigned this Mar 13, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 13, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 13, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 13, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 13, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Linux
  • Verified steps from issue description and brave/brave-core#17586
  • Verified Name and Symbol are left aligned
  • Verified Balances are right aligned
29038.mp4

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from issue description and brave/brave-core#17586
  • Verified Name and Symbol are left aligned
  • Verified Balances are right aligned
29038.mp4

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (arm64)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description and brave/brave-core#17586
  • Verified Name and Symbol are left aligned
  • Verified Balances are right aligned
29038.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants