Skip to content

ERC20 Approve amount is rendered incorrectly when MAX_UINT256 #28980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
josheleonard opened this issue Mar 9, 2023 · 1 comment
Closed

ERC20 Approve amount is rendered incorrectly when MAX_UINT256 #28980

josheleonard opened this issue Mar 9, 2023 · 1 comment
Assignees
@josheleonard
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include

Comments

@josheleonard
Copy link

josheleonard commented Mar 9, 2023 •
edited
Loading

Description

It should instead read "Unlimited ". For any other amount less than MAX_UNINT256, it should rendered as usual.

Screen.Recording.2023-03-09.at.4.37.07.PM.mov
@josheleonard josheleonard added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 9, 2023
@josheleonard josheleonard self-assigned this Mar 9, 2023
@josheleonard josheleonard mentioned this issue Mar 9, 2023
Merged
25 tasks
@josheleonard josheleonard added this to Web3 Mar 9, 2023
@josheleonard josheleonard moved this to In Review in Web3 Mar 9, 2023
@josheleonard
Copy link
Author

closing in favor of: #23666

@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josheleonard